Page MenuHomeFreeBSD

Add rules to build LLVM IR binaries and libraries.

Authored by jonathan on Oct 31 2016, 1:42 AM.



This commmit allows us to run make libfoo.ll or make libfoo.bc
(vs to get the IR version of a library or make foo.full.ll,
etc., to get the IR version of a binary.

As part of this work, we add an LLVM_LINK variable to that can
can be specified/overridden using an external toolchain.

Diff Detail

rS FreeBSD src repository - subversion
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jonathan retitled this revision from to Add rules to build LLVM IR binaries and libraries..
jonathan updated this object.
jonathan edited the test plan for this revision. (Show Details)
jonathan added reviewers: bdrewery, brooks, emaste, rwatson.

Conceptually good.

On pedantic personal preference note, it seems redundant to refer to the change as a commit in the log rather than just saying what is happening and why.

211 ↗(On Diff #21815) seems to be missing CLEANFILES additions.

157 ↗(On Diff #21815)

The PROX_CXX vs !PROG_CXX cases don't appear to be different. Am I missing something?

191 ↗(On Diff #21815)

There seems to be some preexisting whitespace difference after the += there (unless phab is making things up as it sometimes does) which might be made consistent with other nearby lines while you're here.

bdrewery edited edge metadata.

Besides brooks' findings, it seems ok.

This revision is now accepted and ready to land.Oct 31 2016, 9:53 PM
jonathan edited edge metadata.
jonathan marked 3 inline comments as done.
  • Remove redundant C++/non-C++ logic.
  • Improve whitespace consistency.
This revision now requires review to proceed.Nov 1 2016, 12:27 AM

Thanks for the comments: I think I've managed to address them.

211 ↗(On Diff #21815)

Right you are...

157 ↗(On Diff #21815)

Ah, no, you aren't missing anything: this distinction matters in another version of the patch that handles linking to ELF binaries (where we need to know if we include libc++ or not), but not in this patch. In fact, the other patch can probably be simplified too now that this is going in first...

191 ↗(On Diff #21815)

Can do.

brooks edited edge metadata.

Looks good to me

This revision is now accepted and ready to land.Nov 1 2016, 5:21 PM
This revision was automatically updated to reflect the committed changes.