Page MenuHomeFreeBSD

FreeBSD Project Associates
ClosedPublic

Authored by matthew on Apr 17 2017, 7:47 PM.
Tags
None
Referenced Files
F106228275: D10413.id27642.diff
Fri, Dec 27, 1:23 PM
Unknown Object (File)
Wed, Dec 25, 12:58 AM
Unknown Object (File)
Sun, Dec 22, 3:16 AM
Unknown Object (File)
Mon, Dec 16, 7:08 PM
Unknown Object (File)
Sun, Dec 15, 1:17 AM
Unknown Object (File)
Fri, Dec 13, 3:58 AM
Unknown Object (File)
Wed, Dec 11, 1:55 AM
Unknown Object (File)
Wed, Dec 4, 7:44 PM

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Reduce the diff -- remove an extraneous whitespace change.

A textual nit, nothing big.

en_US.ISO8859-1/htdocs/internal/associates.xml
41 ↗(On Diff #27494)

s/the way/the same way/

This revision is now accepted and ready to land.Apr 22 2017, 1:07 PM
This revision was automatically updated to reflect the committed changes.
matthew edited edge metadata.

Revert changes

This revision was automatically updated to reflect the committed changes.

Reopen now we've settled on naming

Back out the backed out changes, reinstating the 'Associate' page.

Rename 'associates.xml' to 'members.xml'

Reword the document in terms of 'Project members' where 'Committers'
are that sub-set of members that have commit bits.

'Membership' rather the 'Member' makes more sense as the link text.

jhb added inline comments.
en_US.ISO8859-1/htdocs/internal/members.xml
18 ↗(On Diff #27898)

I think you can drop this paragraph entirely.

32 ↗(On Diff #27898)

I would simplify this (and use some of the language from your first paragraph above) to say:

Committers are members who have been granted commit access (a "commit bit") to one or more of the Project's repositories.  Committers are expected...
38 ↗(On Diff #27898)

Aren't all members required to abide by the CoC? Also, in the original language, this list of requirements about licensing was required of associates as well. I think perhaps instead we should have a separate itemized list of "obligations" to match the list of "benefits" and move everything starting with "comitters are expected..." into that section and have it apply to all members. That would mean structuring this as:

A FreeBSD Project Member is...

Comitters are members who have been granted commit access...

<h2>Member Responsibilities</h2>
   <li>Contributed material adheres to project's standards and practices.
   <li>Contributed material is correctly attributed to its authors
   <li>Contributed material has appropriate licensing
 
<h2>Member Benefits</h2>
   /* existing "receives" list */

<h2> Committer Benefits</h2>
In addition to member benefits, active committers can vote.

Members MUST create SSH and PGP...

Address points raised by jhb:

  • Drop the introductory paragraph. This (or something like it) can be the preamble to the announcement to announcement message rather than being part of the definitive document.
  • Simplify and reorganise the structure. Explain what all Member benefits are, what all Members responsibilities are in common, and add some text to explain the additional benefits and responsibilities of Committers.
  • Attempt to be consistent in capitalizing terms like 'Project', 'Member', 'Committer' etc.
  • Fix the <!ENTITY title "FreeBSD Project Members"> tag.

Thanks, a few minor suggestions

en_US.ISO8859-1/htdocs/internal/members.xml
32 ↗(On Diff #28100)

Perhaps drop this paragraph now?

44 ↗(On Diff #28100)

Tweak: "Committer Benefits:" to match formatting of earlier <h2> for Member Benefits.

50 ↗(On Diff #28100)

Trailing colon here as well?

62 ↗(On Diff #28100)

I would drop "in exactly the same way as Committers have done previously" as that detail only matters temporarily.

74 ↗(On Diff #28100)

s/designate, that/designate to/. I think this reads a bit clearer as if you drop the clause in commas you get "Core ... should review.."

77 ↗(On Diff #28100)

For this last sentence perhaps "There is no formal definition of inactive accounts. Core and the designated teams will use their own discretion to determine inactivity."

matthew added inline comments.
en_US.ISO8859-1/htdocs/internal/members.xml
32 ↗(On Diff #28100)

I disagree here -- the @FreeBSD.org address is probably the most attractive benefit of becoming a Project Member -- it's the one thing that the rest of the world will be able to see. It's the public acknowledgement of their contribution to the Project.

Address some more commments from jhb:

  • Make the <h2> heading format more consistent
  • Reword the sentence about core delegating the rights to award Member status to other groups.
  • Drop reference to previous status in the requirement for SSH and PGP keys.
en_US.ISO8859-1/htdocs/internal/members.xml
32 ↗(On Diff #28100)

To be clear, by "paragraph" I mean the literal "<p>All members receive:</p>" as it is redundant with the heading in the line above, not to remove the list of benefits.

en_US.ISO8859-1/htdocs/internal/members.xml
32 ↗(On Diff #28100)

Oh, I see. Sorry for the misunderstanding. Yes, I guess that line could go.

More jhb comments: delete a line that serves no real purpose.

Looks good to me. Thanks for being patient with my nit-picking.

This revision is now accepted and ready to land.May 9 2017, 6:22 PM
jonathan added inline comments.
head/en_US.ISO8859-1/htdocs/internal/members.xml
18

"has made a notable contribution" (past tense) or "contributes" (present tense)? We may not be able to clearly articulate how to measure currency of contribution for non-committing members (i.e., there's no simple equivalent to "you must have committed within the last N months"), but isn't the intention that current members are currently contributing to the Project?

head/en_US.ISO8859-1/htdocs/internal/members.xml
18

Hmm... it really should be both. Being awarded "Project Member' status is a recognition of past contributions, but it's also a reward for on-going contributions -- the status should eventually lapse for someone that ceases to contribute.

Re-open to allow updates.

matthew edited edge metadata.

Note that 'FreeBSD Project Members' are expected to be currently
active contributors.

Incorporate gjb's build-fixes and whitespace cleanup.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 10 2018, 4:08 PM
This revision was automatically updated to reflect the committed changes.