Extract suffix rules into bsd.suffixes[-posix].mk.

[jonathan]

Summary

Refactor make suffix rules into separate files (one for POSIX and one not),
and rationalise the rules so that bsd.lib.mk can contain only those rules
that are library-specific (.c.po and .c.So).

This can be accomplished by adding ${STATIC_CFLAGS} to the .c.o rule
unconditionally. STATIC_CFLAGS are only defined for use by sys.mk rules in
lib/libpam/Makefile.inc (see r227797), so it should (should?) be safe to
include them unconditionally in sys.mk's .c.o rule.

[sjg]

share/mk/bsd.lib.mk

93 ↗

(On Diff #17502)

This is insufficient.
You need to either remove the clearing of .SUFFIXES, or re-include the appropriate suffix.mk

[jonathan]

share/mk/bsd.lib.mk

93 ↗

(On Diff #17502)

Ah, yes. I've tried removing the clear .SUFFIXES: line and have kicked off a universe build to see what the overall fallout of this change is. Hopefully there will be results in the morning. :)

[bdrewery]

Please also get a ports exp-run before committing this

share/mk/sys.mk

261 ↗

(On Diff #17502)

This too needs to be added to share/mk/Makefile.

266 ↗

(On Diff #17502)

You need to add this file to share/mk/Makefile so it is installed to /usr/share/mk.

[jonathan]

• Add bsd.suffixes[-posix].mk to share/mk/Makefile.

[jonathan]

Thanks, I've added those to share/mk/Makefile and will request an exp-run.

[jonathan]

• Move .SUFFIXES definitions into suffix rule files, too.

[jonathan]

• Extract suffix rules into bsd.suffixes[-posix].mk.
• Add bsd.suffixes[-posix].mk to share/mk/Makefile.
• Don't clear suffix rules in bsd.lib.mk.

[jonathan]

Ping!

Not that we're well clear of code freezes on -CURRENT (and I think that I've addressed @bdrewery's comments), are folks ok with me committing this?

[sjg]

I've no objection.
Bryan had asked for exp-run ?

[jonathan]

Indeed, I did have that exp-run done:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210331

The result was "0 new failure, looks fine."

[jonathan]

• Merge 'origin/master' into arcpatch-D6805