Lgtm, nice work!

• Tweak the bhyve(8) to reflect the general error code 4.

In D16161#343831, @jhb wrote:

Oof, I failed to realize that some of these errors are not startup related, so maybe just '4 exited due to an error' in the manpage. I do think the earlier changes to use err() were also good changes, I would just stick with '4' for the exit value. However, if you want to commit this as-is for now and adopt err() in place of fprintf/perror + exit as a later change that is ok with me as well. This is fine with me with the manpage tweak (or some similar tweak).

• Address @jhb suggestion.
• Update bhyve(8).

In D16161#343293, @rgrimes wrote:

This is also going to require a man page update, as now there are more than the 4 exit codes listed in the man page.

• Use EX_USAGE instead of EX_TEMPFAIL reported by @rgrimes, I have overlooked this one.

In D16161#342752, @rgrimes wrote:

Looks good over all, just some nits on errx vs err when it appears that there is a proper errno avaliable.

I am not so sure on using sysexits.h either, would rather have a bhyve specific list of error codes as is currently implemented (1 to 4), only expanded to include the any many error conditons that it can exit on.

I have hated tracing down why I get an exit(1) in the code, though this does improve on that some, most of them are just going to be a small set of sysexits codes, and it would greatly help if each exit code was unique and pointed to a very specific problem.

• Use EX_OSERR instead of EX_NOPERM slipped in by mistake.

• Address @rgrimes and @mav comments.
• Where we used to have perror(1) now we use err(3) with the global variabel errno intro(2).

besides what @asomers has pointed out already, all those style(9) must be fixed, also it is necessary to bump the date on the manpage.
Overall, seems very good!!

Update with Leon's comment, Leon is one of the authors of this patch.

• Fix manpage s/MB/MiB/g.
• Remove 'All rights reserved.'.
• Add a comment to explain why we need the variable 'i'.

@lattera-gmail.com first of all thanks for the patch. I'm curious to know what guest OS have you tested inside a jail, could you please share it with me? Also let me know what devices you used, as an example: virtio-blk, virtio-net and etc..

@imp I will answer your other comments next week, I'm moving to a new house and I need to shutdown my office now, that is why I submitted the few things I was already answering..

@bcr Now it is fixed :).

Address @bcr review. Thank you!

• Update this review with the latest patch that @grehan sent me before BSDCan 2018.
• Fixed some style(9). (myself)
• Improved the man page. (myself)

Please add in the commit log:

I'm taking this revision by Peter's request. I will update it soon with the latest patch.

Committed at r335050!

This change is too small for a review, already committed: r335026.

• Remove SPDX-License-Identifier changes already committed at: r335025

In D15768#333595, @pfg wrote:

As a sidenote: one file in bhyve has no license. This is a problem.

In D15774#333376, @rgrimes wrote:

I think you have mis understood what I asked for in the other review. It only needs to be split into 2 parts, one containing the SPDX tags, and another containing all the white space cleanup.

In D15768#333252, @rgrimes wrote:

It is normal to separate all whitespace changes from other. It is preferable to separate all SPDX changes from others when it is sweeping. I strongly assert that as the person now cleaning up a 180k lines and 16 commits of diff involving SPDX tags that this separation occur before this is commited.

In D15768#333234, @rgrimes wrote:

Please seperate this into 2 reviews, one for the white space/tab cleanup and one for the SPDX tag addition.

Thank you

Restore files iov.h, iov.c and pci_virtio_scsi.c removed by mistake. Also fix the last bits in the manpage.

• Fix virtio-scsi uefi-edk2 boot problem: uefi-edk2 VirtioScsi expects that MaxSectors must not be less than 2 at the step 4a -- retrieve and validate features.

In D15596#330255, @imp wrote:

Dang, sorry I stepped on this review with my commit. I missed it somehow. Glad you liked mine better, but I would have coordinated had I noticed this before now.

@imp add a better example at: https://svnweb.freebsd.org/changeset/base/334431

In D15594#329304, @imp wrote:

Thanks for doing this...

Others in the tree if you feel inclined, otherwise a bug might be in order so we don't lose it.

/crypto/heimdal/doc/doxyout/krb5/man/man3/krb5_support.3: assert(s == NULL);
./crypto/heimdal/lib/krb5/krb5_acl_match_file.3: assert(s == NULL);
./lib/libc/gen/cap_rights_get.3:assert(memcmp(&setrights, &getrights, sizeof(setrights)) == 0);
./lib/libpmc/pmclog.3: assert(ev.pl_state == PMCLOG_OK);
./lib/libpmc/pmclog.3: assert(0);
./secure/lib/libcrypto/man/EVP_EncryptInit.3:\& OPENSSL_assert(EVP_CIPHER_CTX_key_length(&ctx) == 16);
./secure/lib/libcrypto/man/EVP_EncryptInit.3:\& OPENSSL_assert(EVP_CIPHER_CTX_iv_length(&ctx) == 16);
./secure/lib/libssl/man/d2i_SSL_SESSION.3: assert(i == j);
./secure/lib/libssl/man/d2i_SSL_SESSION.3: assert(p+i == temp);
./share/man/man3/assert.3:.Dl "assert(1 == 0);"