Page MenuHomeFreeBSD
Feed Advanced Search

Feb 7 2022

royger closed D29602: xen/grant-table: remove explicit linear mapping additions.
Feb 7 2022, 9:16 AM

Feb 3 2022

royger accepted D34153: x86 atomics: use lock prefix unconditionally.

s/read hardware/real hardware/ in the commit message I think.

Feb 3 2022, 10:21 AM

Jan 18 2022

royger committed rGe0516c7553da: x86/apic: remove apic_ops (authored by royger).
x86/apic: remove apic_ops
Jan 18 2022, 9:20 AM
royger committed rG2450da67764c: x86/xen: use x{2}APIC if virtualized by hardware (authored by royger).
x86/xen: use x{2}APIC if virtualized by hardware
Jan 18 2022, 9:20 AM
royger closed D33917: x86/apic: remove apic_ops.
Jan 18 2022, 9:19 AM

Jan 17 2022

royger updated the diff for D33917: x86/apic: remove apic_ops.

Update comment.

Jan 17 2022, 3:54 PM
royger requested review of D33917: x86/apic: remove apic_ops.
Jan 17 2022, 3:53 PM
royger committed rGad15eeeaba30: x86/xen: fallback when VCPUOP_send_nmi is not available (authored by royger).
x86/xen: fallback when VCPUOP_send_nmi is not available
Jan 17 2022, 10:10 AM

Jan 13 2022

royger committed rG7d06c761c8ab: x86/madt: allow Xen guest to use x2APIC mode (authored by royger).
x86/madt: allow Xen guest to use x2APIC mode
Jan 13 2022, 4:16 PM
royger closed D33877: x86/madt: allow Xen guest to use x2APIC mode.
Jan 13 2022, 4:16 PM
royger requested review of D33877: x86/madt: allow Xen guest to use x2APIC mode.
Jan 13 2022, 4:01 PM
royger committed rGca46f3289d96: xen: use an hypercall for shutdown and reboot (authored by royger).
xen: use an hypercall for shutdown and reboot
Jan 13 2022, 3:55 PM
royger edited reviewers for D33876: xen/netfront: deal with mbuf data crossing a page boundary, added: network; removed: royger.
Jan 13 2022, 3:37 PM
royger requested review of D33876: xen/netfront: deal with mbuf data crossing a page boundary.
Jan 13 2022, 3:37 PM

Dec 29 2021

royger closed D33680: mbuf_tags: use explicitly sized type for 'type' parameter.
Dec 29 2021, 8:26 AM
royger committed rG60e749da3c8b: mbuf_tags: use explicitly sized type for 'type' parameter (authored by royger).
mbuf_tags: use explicitly sized type for 'type' parameter
Dec 29 2021, 8:26 AM

Dec 28 2021

royger updated the diff for D33680: mbuf_tags: use explicitly sized type for 'type' parameter.

Fix kp comments

Dec 28 2021, 2:32 PM
royger added a comment to D33680: mbuf_tags: use explicitly sized type for 'type' parameter.

Thanks! Will run the universe build if there are no further comments.

Dec 28 2021, 2:15 PM
royger edited reviewers for D33680: mbuf_tags: use explicitly sized type for 'type' parameter, added: network, transport; removed: royger.
Dec 28 2021, 8:56 AM
royger requested review of D33680: mbuf_tags: use explicitly sized type for 'type' parameter.
Dec 28 2021, 8:56 AM

Nov 23 2021

royger committed R11:e050de4b9c32: sysutils/xen-tools: fix build with clang 13.0.0 (authored by royger).
sysutils/xen-tools: fix build with clang 13.0.0
Nov 23 2021, 1:48 PM
royger committed R11:96cede86ff9a: emulators/xen-kernel: fix build with clang 13.0.0 (authored by royger).
emulators/xen-kernel: fix build with clang 13.0.0
Nov 23 2021, 1:48 PM

Nov 18 2021

royger committed rG50d7d967bbfd: xen/privcmd: fix MMAP_RESOURCE ioctl to copy out results (authored by royger).
xen/privcmd: fix MMAP_RESOURCE ioctl to copy out results
Nov 18 2021, 8:47 AM

Nov 17 2021

royger added inline comments to D30935: xen/intr: move interrupt balancing into xen_intr_alloc_isrc().
Nov 17 2021, 8:39 AM

Nov 16 2021

royger added inline comments to D30935: xen/intr: move interrupt balancing into xen_intr_alloc_isrc().
Nov 16 2021, 4:23 PM

Nov 12 2021

royger added a comment to D30726: xen/intr: rework locking, prepare xen_intr_alloc_isrc() for split.

Thanks for the update, I'm going over the dependencies to check how this all fits together.

Nov 12 2021, 2:55 PM
royger added inline comments to D30935: xen/intr: move interrupt balancing into xen_intr_alloc_isrc().
Nov 12 2021, 2:49 PM

Nov 10 2021

royger added a comment to D30726: xen/intr: rework locking, prepare xen_intr_alloc_isrc() for split.

Forgot to hit summit yesterday...

Nov 10 2021, 4:35 PM

Nov 8 2021

royger added a comment to D30726: xen/intr: rework locking, prepare xen_intr_alloc_isrc() for split.

I'm unsure you actually need to split those apart. Wouldn't Arm also require some kind of locking of the architecture specific bits?

See D30936. The goal is everything being protected by xen_intr_x86_lock is very x86-specific and destined to split away from this file. Whereas the portions which remain protected by xen_intr_isrc_lock are mostly architecture-independent and will remain in this file. Splitting the locks allows them to be static.

Nov 8 2021, 5:27 PM
royger added a comment to D30726: xen/intr: rework locking, prepare xen_intr_alloc_isrc() for split.

I'm unsure you actually need to split those apart. Wouldn't Arm also require some kind of locking of the architecture specific bits?

Nov 8 2021, 3:31 PM

Oct 27 2021

royger added a comment to D31206: xen: remove leftover bits missed in commit ac3ede5371.

Can you please base this on top of current code? AFAICT there's no need to move those fields to xen_arch_isrc just to end up removing them afterwards.

Oct 27 2021, 4:10 PM
royger accepted D31206: xen: remove leftover bits missed in commit ac3ede5371.
Oct 27 2021, 4:04 PM

Oct 21 2021

royger committed rG5bb67f5f3f59: xen/devices: purge uses of intr_machdep.h (authored by ehem_freebsd_m5p.com).
xen/devices: purge uses of intr_machdep.h
Oct 21 2021, 7:41 AM
royger closed D29959: xen/devices: purge uses of intr_machdep.h.
Oct 21 2021, 7:41 AM
royger committed rG535badd1b8d2: xen/pcifront: purge from tree (authored by royger).
xen/pcifront: purge from tree
Oct 21 2021, 7:41 AM

Oct 20 2021

royger added inline comments to D29959: xen/devices: purge uses of intr_machdep.h.
Oct 20 2021, 10:34 AM

Oct 15 2021

royger accepted D29959: xen/devices: purge uses of intr_machdep.h.

LGTM, will push

Oct 15 2021, 8:35 AM

Sep 17 2021

royger accepted D32008: Remove support for FreeBSD 11.4.

For Xen bits.

Sep 17 2021, 8:03 PM

Aug 31 2021

royger added a comment to D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.

No, then you would be doing arithmetic on a void pointer, which isn't officially legal (size of void being undefined). Better to do the math on integers and cast to the correct type.

Aug 31 2021, 4:50 PM
royger added a comment to D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.

On second thought it might have been easier to just cast to void * and forget about the parentheses.

Aug 31 2021, 2:46 PM

Aug 29 2021

royger added a comment to D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.
In D31711#715619, @dim wrote:

I think you can also remove the cast to vm_paddr_t while there, the field is declared as uint64_t.

Hm, won't that give problems on i386? I'll see what a i386 build does.

Aug 29 2021, 3:53 PM
royger accepted D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.

I think you can also remove the cast to vm_paddr_t while there, the field is declared as uint64_t.

Aug 29 2021, 2:15 PM

Aug 12 2021

royger committed rG5e4279a8f35a: loader: fix multiboot loading on UEFI (authored by royger).
loader: fix multiboot loading on UEFI
Aug 12 2021, 7:24 AM
royger committed rGf4c6843ec2b9: xen: use correct cache attributes for Xen specific memory regions (authored by royger).
xen: use correct cache attributes for Xen specific memory regions
Aug 12 2021, 7:24 AM
royger closed D31507: loader: fix multiboot loading on UEFI.
Aug 12 2021, 7:24 AM
royger added a comment to D31507: loader: fix multiboot loading on UEFI.
In D31507#710357, @kib wrote:

Note that 'relocatable' means variyng not VA, but PA. Loader still maps the kernel at KERNBASE.

Aug 12 2021, 6:48 AM

Aug 11 2021

royger requested review of D31507: loader: fix multiboot loading on UEFI.
Aug 11 2021, 3:05 PM

Aug 2 2021

royger committed rG82bf6a2566ba: xen/timer: fix amd64 LINT kernel build (authored by royger).
xen/timer: fix amd64 LINT kernel build
Aug 2 2021, 9:33 AM

Jul 28 2021

royger committed rGac959cf54421: xen: introduce xen_has_percpu_evtchn() (authored by julien_xen.org).
xen: introduce xen_has_percpu_evtchn()
Jul 28 2021, 3:31 PM
royger committed rG46c46edd1889: xen/control: print warning on call of xctrl_suspend() (authored by julien_xen.org).
xen/control: print warning on call of xctrl_suspend()
Jul 28 2021, 3:31 PM
royger committed rG7de88bb4a2e8: xen/grant_table: cleanup max_nr_grant_frames() (authored by ehem_freebsd_m5p.com).
xen/grant_table: cleanup max_nr_grant_frames()
Jul 28 2021, 3:31 PM
royger closed D29402: xen: introduce xen_support_evtchn_bind().
Jul 28 2021, 3:30 PM
royger committed rG0b4f30c2366c: xen/control: introduce xen_pv_shutdown_handler() (authored by julien_xen.org).
xen/control: introduce xen_pv_shutdown_handler()
Jul 28 2021, 3:30 PM
royger closed D29599: xen/control: print warning on call of xctrl_suspend().
Jul 28 2021, 3:30 PM
royger committed rG69c6eee7567b: xen: introduce xen_pv_disks_disabled() (authored by julien_xen.org).
xen: introduce xen_pv_disks_disabled()
Jul 28 2021, 3:30 PM
royger closed D29840: xen/grant_table: cleanup max_nr_grant_frames().
Jul 28 2021, 3:30 PM
royger committed rG5f7000832791: xen/netfront: introduce xen_pv_nics_disabled() (authored by julien_xen.org).
xen/netfront: introduce xen_pv_nics_disabled()
Jul 28 2021, 3:30 PM
royger closed D29406: xen/control: introduce xen_pv_shutdown_handler().
Jul 28 2021, 3:30 PM
royger committed rGc89f1f12b07b: xen/xen-os: move inclusion of machine/xen-os.h later (authored by ehem_freebsd_m5p.com).
xen/xen-os: move inclusion of machine/xen-os.h later
Jul 28 2021, 3:30 PM
royger closed D29403: xen: introduce xen_pv_disks_disabled().
Jul 28 2021, 3:30 PM
royger committed rGe627e25d761f: xen/xenpv: remove low memory limit for non-x86 (authored by ehem_freebsd_m5p.com).
xen/xenpv: remove low memory limit for non-x86
Jul 28 2021, 3:30 PM
royger closed D29405: xen/netfront: introduce xen_pv_nics_disabled().
Jul 28 2021, 3:30 PM
royger committed rG9976c5a540c1: xen/intr: use __func__ instead of function names (authored by ehem_freebsd_m5p.com).
xen/intr: use __func__ instead of function names
Jul 28 2021, 3:30 PM
royger closed D29811: xen/xen-os: move inclusion of machine/xen-os.h later.
Jul 28 2021, 3:29 PM
royger committed rGae5981274815: xen/timer: make xen timer optional (authored by julien_xen.org).
xen/timer: make xen timer optional
Jul 28 2021, 3:29 PM
royger closed D29304: xen/xenpv: remove low memory limit for non-x86.
Jul 28 2021, 3:29 PM
royger committed rG5ca00e0c985f: xen/intr: use struct xenisrc * as xen_intr_handle_t (authored by ehem_freebsd_m5p.com).
xen/intr: use struct xenisrc * as xen_intr_handle_t
Jul 28 2021, 3:29 PM
royger closed D29499: xen/intr: use __func__ instead of function names.
Jul 28 2021, 3:29 PM
royger committed rGd3705b5a7fac: xen/control: gate x86 specific code in the preprocessor (authored by ehem_freebsd_m5p.com).
xen/control: gate x86 specific code in the preprocessor
Jul 28 2021, 3:29 PM
royger closed D29041: xen/timer: make xen timer optional.
Jul 28 2021, 3:29 PM
royger committed rGd561380eb31e: xen/xen-os: don't let anyone else defining __XEN_INTERFACE_VERSION__ (authored by julien_xen.org).
xen/xen-os: don't let anyone else defining __XEN_INTERFACE_VERSION__
Jul 28 2021, 3:29 PM
royger closed D29500: xen/intr: use struct xenisrc * as xen_intr_handle_t.
Jul 28 2021, 3:28 PM
royger closed D29306: xen/control: disable 15226522304868a8312a84f8ff549fdc6bbf54db on !x86.
Jul 28 2021, 3:28 PM
royger committed rGa48f7ba444fd: xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c (authored by julien_xen.org).
xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c
Jul 28 2021, 3:28 PM
royger committed rGb6ff9345a46a: xen: create VM_MEMATTR_XEN for Xen memory mappings (authored by ehem_freebsd_m5p.com).
xen: create VM_MEMATTR_XEN for Xen memory mappings
Jul 28 2021, 3:28 PM
royger closed D29407: xen/xen-os: don't let anyone else defining __XEN_INTERFACE_VERSION__.
Jul 28 2021, 3:28 PM
royger closed D29042: xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c.
Jul 28 2021, 3:28 PM
royger closed D29351: xen: create VM_MEMATTR_XEN for Xen memory mappings.
Jul 28 2021, 3:28 PM
royger added inline comments to D29041: xen/timer: make xen timer optional.
Jul 28 2021, 3:21 PM
royger added inline comments to D29405: xen/netfront: introduce xen_pv_nics_disabled().
Jul 28 2021, 1:20 PM

Jul 14 2021

royger added a comment to D29402: xen: introduce xen_support_evtchn_bind().

I would name this xen_percpu_evtchn{_enabled} or some such. Given the current usage I think xen_support_evtchn_rebind is confusing, as it's not about rebinding an event channel, but being able to assign event channels to vCPUs.

Jul 14 2021, 11:30 AM

Jul 7 2021

royger committed R11:53c01d65985f: sysutils/xen-tools: fix build with go installed (authored by royger).
sysutils/xen-tools: fix build with go installed
Jul 7 2021, 7:23 AM

Jul 2 2021

royger added inline comments to D29733: kvmclock driver with vDSO support.
Jul 2 2021, 7:26 AM

Jul 1 2021

royger added inline comments to D29733: kvmclock driver with vDSO support.
Jul 1 2021, 11:09 AM

Jun 30 2021

royger added a comment to D29733: kvmclock driver with vDSO support.

Just replied to the most controversial part I think, will try to review the rest tomorrow. Thanks!

Jun 30 2021, 5:33 PM

Jun 22 2021

royger committed R11:fa0f04a80fb6: emulators/xen-kernel: import fix for cache attributes (authored by royger).
emulators/xen-kernel: import fix for cache attributes
Jun 22 2021, 2:55 PM
royger committed R11:d0e59dedfb1b: emulators/xen-kernel: remove stale patch files (authored by royger).
emulators/xen-kernel: remove stale patch files
Jun 22 2021, 2:55 PM

Jun 16 2021

royger added a comment to D29733: kvmclock driver with vDSO support.

Thanks and sorry for the delay! Mostly nits, I think the only major question is whether you need to use the dma system to allocate the memory for the vcpu time infos. I think it would be fine to just use plain malloc.

Jun 16 2021, 3:17 PM
royger resigned from D30278: sysutils/edk2: Rename xen flavor to xen_x64.
Jun 16 2021, 1:00 PM

Jun 15 2021

royger added inline comments to D30648: xen/intr: move x86 bits into xen_arch_isrc_t structure.
Jun 15 2021, 9:38 AM

Jun 11 2021

royger added a comment to D30725: xen/intr: protect xen_intr_port_to_isrc[] during resume.

Thanks! For the record: the lock is not currently needed given the only caller has APs and interrupts disabled. I'm fine with adding this safeguard, but it should be noted in the commit message IMO that this is not currently an issue.

Jun 11 2021, 3:09 PM

May 20 2021

royger committed R11:8790f67654a9: sysutils/xen-tools: improve ivshmem check (authored by royger).
sysutils/xen-tools: improve ivshmem check
May 20 2021, 1:48 PM
royger committed R11:97632df2b3f8: sysutils/xen-tools: fix build on FreeBSD 12 (authored by royger).
sysutils/xen-tools: fix build on FreeBSD 12
May 20 2021, 7:00 AM
royger closed D30329: sysutils/edk2: update to 202102.
May 20 2021, 7:00 AM
royger committed R11:ef0c9c2a7940: sysutils/edk2: update to 202102 (authored by royger).
sysutils/edk2: update to 202102
May 20 2021, 7:00 AM
royger closed D30328: sysutils/edk2: use default gcc.
May 20 2021, 7:00 AM
royger committed R11:998bc2159759: sysutils/edk2: use default gcc (authored by royger).
sysutils/edk2: use default gcc
May 20 2021, 7:00 AM

May 18 2021

royger requested review of D30329: sysutils/edk2: update to 202102.
May 18 2021, 11:30 AM
royger requested review of D30328: sysutils/edk2: use default gcc.
May 18 2021, 11:28 AM
royger committed rG9e14ac116e70: x86/xen: further PVHv1 removal cleanup (authored by royger).
x86/xen: further PVHv1 removal cleanup
May 18 2021, 8:45 AM