LGTM now, thanks!

I'd like to request that the change be either extended to disable RTREE (my preference; we don't use rtree in base either), or reduced to build with FTS4 (to match upstream; arguably FTS5 should be also enabled if that's the approach taken) for consistency.

In D18536#400014, @jpaetzel wrote:

In D18536#400013, @markj wrote:

In D18536#395272, @jpaetzel wrote:

In D18536#395145, @delphij wrote:

LGTM (the unlocked use of sc->ioctl_data_mem looks worrisome to me, but the proposed change won't worsen the situation). Do you have a chance to test this on real hardware? (@jpaetzel do you know someone who may be able to help with that?).

My last 9750 died a while ago. I'll ping Austin @ ix to see if he can rig up a system for us to test with.

Ping?

I haven't been deemed worthy of a reply, so I guess that's a no.

In D18689#398817, @loader wrote:

I would think this would affect any program that calls strftime(3) with abbreviated weekday name (%a),
for example ps(1):

https://svnweb.freebsd.org/base/head/bin/ps/print.c?revision=335023&view=markup#l411

410             } else if (now - k->ki_p->ki_start.tv_sec < 7 * 86400) {
411                             (void)strftime(buf, buflen, "%a%H  ", tp);

then it would just print out a 五 here instead of 周五:

% env LANG=zh_CN.UTF-8 ps auwwx | grep '[s]bin/sshd'
root 26612  0.0  0.0 20784  100  -  IsJ  五12    0:00.02 /usr/sbin/sshd

% env LANG=en_US.UTF-8 ps auwwx | grep '[s]bin/sshd'
root 26612  0.0  0.0 20784  100  -  IsJ  Fri12   0:00.02 /usr/sbin/sshd

Rebase after r342614.

Properly set MIME type for zh_CN.UTF-8.src.

Looks good to me (except please do use FBSD_1.6 version).

LGTM (the unlocked use of sc->ioctl_data_mem looks worrisome to me, but the proposed change won't worsen the situation). Do you have a chance to test this on real hardware? (@jpaetzel do you know someone who may be able to help with that?).

Remove ICH8M specific initialization.

LGTM, thanks!

LGTM.

LGTM.

Please take another look, thanks!

Address style(9) issues pointed out by oshogbo.

Correct size for dryrun.

I think you might want to bump the date (currently read as "January 10, 1995") when committing but it looks otherwise fine to me.

Minor nit: could you please quote variables with {} (e.g. $VAR -> ${VAR})?

LGTM

LGTM.

LGTM, thanks!

Looks reasonable.

LGTM.

This is reasonable.

LGTM (but are we expecting COMPAT_FREEBSD11 defined in places where FreeBSD is not defined?)

Mostly LGTM.

This would increase stack usage for /dev/random read by 32 bytes, but I think it's small enough and make the code easier to reason for MP safety (the buffer is not meant to be shared by two different threads), so consider this a LGTM from secteam@ as long as there is no objection raised by September 1st.

Looks good to me. @jmg do you have any concerns if this is landed as-is?

LGTM from an earlier review.