Page MenuHomeFreeBSD

random(4): Correct a bare zero to the appropriate enum
ClosedPublic

Authored by cem on Sep 1 2018, 4:45 AM.

Details

Summary

The convention for updating hc_destination[] is to index with a
random_entropy_source. Zero happens to match RANDOM_CACHED, which is
correct for this source (early random data). Spell the zero value as the
enum name instead of the magic constant.

No functional change.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cem created this revision.Sep 1 2018, 4:45 AM
delphij accepted this revision.Sep 1 2018, 5:54 AM
delphij added a subscriber: delphij.

Looks reasonable.

sys/dev/random/random_harvestq.c
421 ↗(On Diff #47555)

@markm -- Why is this explicit_bzero() done here in the loop instead of done below (e.g. line 423)?

This revision is now accepted and ready to land.Sep 1 2018, 5:54 AM
markm accepted this revision.Sep 1 2018, 10:07 AM
markm added inline comments.
sys/dev/random/random_harvestq.c
421 ↗(On Diff #47555)

Over-paranoia, I guess. I wouldn't object to it moving.

cem added inline comments.Sep 1 2018, 6:59 PM
sys/dev/random/random_harvestq.c
421 ↗(On Diff #47555)

One other caveat is that random_harvestq_fast_process_event -> random_fortuna_process_event() also explicit_bzeros the event in the loop already.

This revision was automatically updated to reflect the committed changes.