Re-add the kstat.zfs.misc.arcstats.other_size sysctl.
ClosedPublic
Actions

Authored by markj on Aug 29 2018, 3:15 PM.

Details

Reviewers

allanjude
mmacy
mav
jpaetzel

Group Reviewers

ZFS

Commits

rS338395: Re-add kstat.zfs.misc.arcstats.other_size under COMPAT_FREEBSD11.

Summary

It is used by top(1), among other things, and was removed in r337653,
where it was split into three finer-grained statistics. We aim to
provide backward compatibility for such utilities, so re-add the
other_size sysctl under COMPAT_FREEBSD11.

The reintegration is kind of ugly, but I don't see a better way to do it
without extending the kstat KPI.

Test Plan

Tested using top(1) with r337661 reverted.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 29 2018, 3:15 PM

Herald added a subscriber: delphij. · View Herald TranscriptAug 29 2018, 3:15 PM

Harbormaster completed remote builds in B19262: Diff 47441.Aug 29 2018, 3:15 PM

markj edited the test plan for this revision. (Show Details)Aug 29 2018, 3:17 PM

markj added reviewers: allanjude, mmacy.

allanjude accepted this revision.Aug 29 2018, 5:51 PM

allanjude added reviewers: mav, jpaetzel, ZFS.

This revision is now accepted and ready to land.Aug 29 2018, 5:51 PM

LGTM (but are we expecting COMPAT_FREEBSD11 defined in places where FreeBSD is not defined?)

In D16943#361472, @delphij wrote:

LGTM (but are we expecting COMPAT_FREEBSD11 defined in places where FreeBSD is not defined?)

I don't think so. I'm just following the existing convention of using #ifdef FreeBSD to delineate FreeBSD-specific modifications. Maybe it would be more clear as

#ifdef __FreeBSD__
#ifdef COMPAT_FREEBSD11
...

I don't have strong feelings either way.

I'd much rather have the ifdef on a single line.

Closed by commit rS338395: Re-add kstat.zfs.misc.arcstats.other_size under COMPAT_FREEBSD11. (authored by markj). · Explain WhyAug 30 2018, 1:42 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptAug 30 2018, 1:42 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

cddl/

contrib/

opensolaris/

uts/

common/

fs/

zfs/

arc.c

14 lines

Diff 47485

View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c

Re-add the kstat.zfs.misc.arcstats.other_size sysctl.ClosedPublicActions