Page MenuHomeFreeBSD

Fortuna: trivial static variable cleanup
ClosedPublic

Authored by cem on Aug 29 2018, 4:43 AM.

Details

Summary

Remove unnecessary use of function-local static variable. 32 bytes is
small enough to live on the stack.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cem created this revision.Aug 29 2018, 4:43 AM

This would increase stack usage for /dev/random read by 32 bytes, but I think it's small enough and make the code easier to reason for MP safety (the buffer is not meant to be shared by two different threads), so consider this a LGTM from secteam@ as long as there is no objection raised by September 1st.

cem added a comment.Aug 29 2018, 6:15 PM

This would increase stack usage for /dev/random read by 32 bytes, but I think it's small enough and make the code easier to reason for MP safety (the buffer is not meant to be shared by two different threads), so consider this a LGTM from secteam@ as long as there is no objection raised by September 1st.

Yeah, the buffer should not be shared and it is a tiny amount of stack space. Our /dev/random read stacks are not super deep. (This isn't a security issue or implementation flaw due to the exclusive RANDOM_RESEED mutex being held over all accesses.) Thanks!

markm accepted this revision.Aug 29 2018, 7:29 PM

If it doesn't crash anything, then fine! I had stack problems at some point.

This revision is now accepted and ready to land.Aug 29 2018, 7:29 PM
delphij accepted this revision.Aug 29 2018, 8:55 PM
delphij accepted this revision.
delphij added a reviewer: secteam.
This revision was automatically updated to reflect the committed changes.