Page MenuHomeFreeBSD

Fix excessive reseed rate in random(4).
ClosedPublic

Authored by markm on Aug 23 2018, 4:46 PM.

Details

Summary

Fix braino of mine where the reseeds would happen far too often, making the kernel process way too busy.
PR: 230808
Submitted by: Conrad Meyer <cem@FreeBSD.org>
Reported by: Danilo Egea Gondolfo <danilo@FreeBSD.org>

Test Plan

Make the PRNG work hard while doing something intensive like "make
world". To make the PRNG work hard, do e.g.
$ dd if=/dev/random of=/dev/null bs=$((1024*1024))

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markm created this revision.Aug 23 2018, 4:46 PM
markm added a reviewer: delphij.EditedAug 23 2018, 4:59 PM

Apologies to delphij for abandoning the previous identical-looking commit. I was making a pig's ear of the archanist work.

delphij accepted this revision.Aug 23 2018, 5:08 PM

LGTM from an earlier review.

This revision is now accepted and ready to land.Aug 23 2018, 5:08 PM
cem accepted this revision.Aug 23 2018, 5:14 PM

Copied from earlier review D16866:

This one looks obviously correct to me. Go ahead and commit it. It fixes a security weakness in our implementation relative to spec Fortuna, so I'd be sure to tag the commit with "Security: yes."

markm added a comment.Aug 23 2018, 7:19 PM

Thanks folks! Tinderbox build going, then I'll commit.

This revision was automatically updated to reflect the committed changes.