Page MenuHomeFreeBSD

Fix excessive reseed rate in random(4).
ClosedPublic

Authored by markm on Aug 23 2018, 4:46 PM.
Tags
None
Referenced Files
F133024663: D16872.id.diff
Wed, Oct 22, 4:31 AM
F133024633: D16872.id47181.diff
Wed, Oct 22, 4:31 AM
F133024627: D16872.id47234.diff
Wed, Oct 22, 4:31 AM
Unknown Object (File)
Tue, Oct 21, 4:33 PM
Unknown Object (File)
Thu, Oct 16, 2:56 AM
Unknown Object (File)
Sat, Oct 11, 9:09 PM
Unknown Object (File)
Sun, Sep 28, 1:12 PM
Unknown Object (File)
Fri, Sep 26, 10:34 PM
Subscribers

Details

Summary

Fix braino of mine where the reseeds would happen far too often, making the kernel process way too busy.
PR: 230808
Submitted by: Conrad Meyer <cem@FreeBSD.org>
Reported by: Danilo Egea Gondolfo <danilo@FreeBSD.org>

Test Plan

Make the PRNG work hard while doing something intensive like "make
world". To make the PRNG work hard, do e.g.
$ dd if=/dev/random of=/dev/null bs=$((1024*1024))

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Apologies to delphij for abandoning the previous identical-looking commit. I was making a pig's ear of the archanist work.

LGTM from an earlier review.

This revision is now accepted and ready to land.Aug 23 2018, 5:08 PM

Copied from earlier review D16866:

This one looks obviously correct to me. Go ahead and commit it. It fixes a security weakness in our implementation relative to spec Fortuna, so I'd be sure to tag the commit with "Security: yes."

Thanks folks! Tinderbox build going, then I'll commit.

This revision was automatically updated to reflect the committed changes.