Page MenuHomeFreeBSD

update ZFS to note support of extended attributes
AcceptedPublic

Authored by jmg on Oct 12 2018, 10:38 PM.

Details

Reviewers
freqlabs
Group Reviewers
manpages

Diff Detail

Repository
rS FreeBSD src repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20171
Build 19657: arc lint + arc unit

Event Timeline

cddl/contrib/opensolaris/cmd/zfs/zfs.8
1565

Maybe rephrase this to something like, xattrs=off has no effect on .Fx? Looking at the code it seems like that we basically ignored xattr=off due to lack of VFS_XATTR?

For posterity's sake, the context of this review is a conversation on Twitter regarding the state of xattr/EA in FreeBSD for ZFS, with a special eye to multi-labels.

allanjude added a subscriber: allanjude.

Ryan has been working on commonize-ing some of the way this works upstream in OpenZFS, he may have useful input.

@freqlabs let ms know if you just want to integrate this into the OpenZFS update, or what.

Thanks.

Yes a PR clarifying this in OpenZFS would be greatly appreciated. Any change here would only be good for MFC. I think the wording suggested by @delphij is a bit more clear.

Yes a PR clarifying this in OpenZFS would be greatly appreciated. Any change here would only be good for MFC. I think the wording suggested by @delphij is a bit more clear.

Well, it looks like OpenZFS's zfsprops.8 doesn't have the wording that FreeBSD doesn't support xattr. and it looks generic that it doesn't leave any OS specific changes, so I won't be submitting anything to OpenZFS for this change.

Fix the date of course.

This revision is now accepted and ready to land.Jul 20 2020, 8:32 PM