Page MenuHomeFreeBSD

random(4): Translate a comment requirement into a compile-time invariant
ClosedPublic

Authored by cem on Sep 1 2018, 4:39 AM.
Tags
None
Referenced Files
F165636985: D16982.id49355.diff
Sat, Aug 8, 10:12 PM
F165594330: D16982.id47554.diff
Sat, Aug 8, 6:31 PM
F165583127: D16982.id49355.diff
Sat, Aug 8, 5:48 PM
Unknown Object (File)
Fri, Aug 7, 10:18 AM
Unknown Object (File)
Thu, Aug 6, 12:53 PM
Unknown Object (File)
Sat, Jul 25, 6:19 PM
Unknown Object (File)
Sat, Jul 25, 6:04 AM
Unknown Object (File)
Sat, Jul 18, 2:59 AM
Subscribers

Details

Summary

In various places, random represents the set of sources as a 32-bit word
bitmask. It assumes all sources fit within this, i.e., the maximum valid
source number is 31.

There was a comment specifying this limitation, but we can actually refuse
to compile if our assumption is violated instead. We still have a few spare
random source slots, but sooner or later someone may need to convert the
masks used from raw 32-bit words to bitset(9) APIs.

This prevents some kinds of developer foot-shooting when adding new random
sources. No functional change.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable