As discussed in the email thread entitled "Re: svn commit: r342175 - in vendor/sqlite3/dist: . tea tea/doc tea/generic tea/tclc", disable FTS3 and FTS4 as suggested by delphij@.
Details
Details
- Reviewers
delphij emaste gordon - Group Reviewers
secteam - Commits
- rS349650: MFC r342972:
rS342972: Disable FTS3, FTS4, and RTREE in bundled and private sqlite3.
Tinderbox on universe13a and I will use on my systems here for a few days.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I'd like to request that the change be either extended to disable RTREE (my preference; we don't use rtree in base either), or reduced to build with FTS4 (to match upstream; arguably FTS5 should be also enabled if that's the approach taken) for consistency.
| lib/libsqlite3/Makefile | ||
|---|---|---|
| 38 ↗ | (On Diff #52675) | I only asked for FTS3 being disabled because it's disabled upstream :) Note that we are not using R*Tree extension either in the base system, so if the philosophy is to use a minimized version of SQLite, that should be disabled too. If the goal is to match upstream, then we should enable both FTS4 and FTS5. Personally, I'm inclined to adopt the minimize approach (remove FTS3, FTS4 and RTREE), though, because this is a private library. I'd like to see crypto/heimdal/lib/sqlite/ gone in a separate change as well. It's harmless (because it's not connected to build) but might cause confusion. |
Comment Actions
I'll submit a new revision when I get home.
| lib/libsqlite3/Makefile | ||
|---|---|---|
| 38 ↗ | (On Diff #52675) | Agreed, the base sqlite3 should be as minimal as possible, which is why I removed FTS3, FTS4 and RTREE, it's a private library. I'll update this revision to remove RTREE as soon as I get home. The bundled sqlite3 in heimdal has been removed. |
Comment Actions
Also disable RTREE.
sqlite3 in base is private, thus FTS3, FTS4 & RTREE are not needed.