Track down copyright holders / original authors as best I can.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jul 11 2018
Jul 11 2018
In D16205#344062, @bz wrote:Given this is multiple architectures, how are you dealing with colliding/different values? Hmm I see you don't touch that part.
The observant will notice there's still a copy in the EFI loader... that will be removed in a different review
Rework somewhat before sys/boot.h gets too out of control.
Jul 10 2018
Jul 10 2018
Review nits noted so far.
Tweak documentation to RB_ constants to reflect current use
Jul 9 2018
Jul 9 2018
Remove gateworks nanobsd support.
Remove armeb from the list of architectures we build for the boot
Remove dirs that git svn should have removed but didn't.
Jul 8 2018
Jul 8 2018
imp added inline comments to D16186: Avoid depending on system headers from the source tree during bootstrap.
Remove stray space from PNP string.
Add PNP info to PCI attachment of et driver
Add PNP info to PCI attachment of ipw driver
Add PNP info to PCI attachment of ixv driver
Add PNP info to PCI attachment of ix driver
Add PNP info to PCI attachments of ciss driver
Add PNP info to PCI attachment of dc driver
Add PNP info to PCI attachments of bge driver
Add PNP info to PCI attachments of bfe driver
Add PNP info to PCI attachment of alc driver
Add PNP info to PCI attachment of gem driver
Add PNP info to PCI attachment of fxp driver
Add PNP info to PCI attachment of ena driver
Add PNP info to PCI attachment of cas driver
Stop using ../zfs/libzfs.h but instead use libzfs.h.
Jul 7 2018
Jul 7 2018
Update AMDSMB to use PCI_MATCH
Switch to using new PCI_MATCH stuff.
Create PCI_MATCH and pci_match_device
Mention the need to update devmatch.conf
Jul 5 2018
Jul 5 2018
this has been committed and got into a weird state.
Jul 4 2018
Jul 4 2018
Jul 2 2018
Jul 2 2018
So I'm confused a little.
In D16080#341032, @eadler wrote:I am not dropping this discussion, just going to split this review up. Expect to see an updated review, with your comments addressed, in the next week or so
Jul 1 2018
Jul 1 2018
so you have both thread_lite and offset generator... Why?
Rather than (int *)((char *)td + offset), you might need to do (int *)((uinptr_t)td + offset) to get around alignment changed warnings.
a couple of preliminary comments, more later.
Mention, belatedly, the need to run mergemaster. This somehow
So what's a tied module?
Jun 29 2018
Jun 29 2018
Jun 28 2018
Jun 28 2018
Revert preference to be an int.
Fix quoting in sending the NOMATCH event to devmatch
update, per jhb feedback
- Create PCI_MATCH and pci_match_device
- Switch to using new PCI_MATCH stuff.
We're not, yet, at C++11 capable on all our plaforms.
Jun 27 2018
Jun 27 2018
Safely quote all variable expansions.
Generally quite good. A few questions about some code that doesn't quite look right.
I wouldn't worry about it...
pccard: recode to use devctl_safe_quote_sb instead of devctl_safe_quote.
Remove devctl_safe_quote since it's now unused.
Fix devctl generation for core files.
Create new devctl_safe_quote_sb to copy a source string into a struct
imp retitled D16026: Fix core dump reporting from devctl from Fix bug in loop termination. to Fix core dump reporting from devctl.
- Create new devctl_safe_quote_sb to copy a source string into a struct
- Fix devctl generation for core files.
- pccard: recode to use devctl_safe_quote_sb instead of devctl_safe_quote.
- Remove devctl_safe_quote since it's now unused.
Jun 26 2018
Jun 26 2018
After I did my commit, I noticed something odd. g_vfs_strategy is generally unused outside of geom, but BO_STRATEGY is used instead.
Use buf + strategy rather than bypassing geom_vfs layer
Jun 25 2018
Jun 25 2018
This is fine. -P on UEFI is hit or miss, and I'm not sure why.
Otherwise, this looks good to my eye...
imp added a comment to D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.
Looks OK to me.
imp added a comment to D15995: Add PNP info to PCI attachment of alc, amdsmb, bfe, bge, ce, dpt, dc, ciss, cp drivers.
In D15995#338704, @lakhanshiva_gmail.com wrote:If I m not wrong this approach is specifically for the atheros drivers.
Isn't it ?
Jun 24 2018
Jun 24 2018
imp added a comment to D15995: Add PNP info to PCI attachment of alc, amdsmb, bfe, bge, ce, dpt, dc, ciss, cp drivers.
Please see https://reviews.freebsd.org/D15999 for a notion on how we might want to cut over the medium drivers to being table driven.
- Create PCI_MATCH and pci_match_device
- Switch to using new PCI_MATCH stuff.
Don't use generic PCI_VENDOR and PCI_PRODUCT macros. Prefix them with
imp added a comment to D15979: Add PNP info to PCI attachment of et, iir, ignore, isab, ips, ipw, ismt, iwm, ix, ixgb, ixv drivers.
I think we should consider doing a pci_lookup() routine. It would make a lot of this simpler...
Jun 23 2018
Jun 23 2018
Jun 21 2018
Jun 21 2018
Jun 20 2018
Jun 20 2018
I've updated things to be better. We set the baud rate in the environment, and then just before we boot, and we're a EFI console, we get it and some other things to try to piece together the right hw.uart.console value to set if we're booting serial and we are the EFI console.