Page MenuHomeFreeBSD

Fix core dump reporting from devctl
ClosedPublic

Authored by imp on Jun 26 2018, 10:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 1:01 AM
Unknown Object (File)
Sep 25 2023, 9:08 PM
Unknown Object (File)
Sep 25 2023, 9:06 PM
Unknown Object (File)
Sep 25 2023, 8:52 PM
Unknown Object (File)
Sep 6 2023, 10:06 PM
Unknown Object (File)
Aug 29 2023, 10:25 PM
Unknown Object (File)
Jul 5 2023, 9:39 PM
Unknown Object (File)
May 14 2023, 6:29 AM
Subscribers
None

Details

Reviewers
imp
Summary

Create new devctl_safe_quote_sb to copy a source string into a struct sbuf to make it safe. Callers are expected to add the " " around it, if needed.

Fix devctl generation for core files.

We have a problem with vn_fullpath_global when the file exists. Work
around it by printing the full path if the core file name starts with /,
or current working directory followed by the filename if not.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17650
Build 17455: arc lint + arc unit

Event Timeline

  • Create new devctl_safe_quote_sb to copy a source string into a struct
  • Fix devctl generation for core files.
  • pccard: recode to use devctl_safe_quote_sb instead of devctl_safe_quote.
  • Remove devctl_safe_quote since it's now unused.
imp retitled this revision from Fix bug in loop termination. to Fix core dump reporting from devctl.Jun 27 2018, 1:25 AM
imp edited the summary of this revision. (Show Details)
imp added inline comments.
sys/dev/pccard/pccard.c
43

This change, and the interface removal are separate commits.

sys/kern/kern_sig.c
3546–3560

This is the meat of the change. There's likely better ways to do this, but this one works when the file exists so is better than the old way. It didn't and we'd lose reporting events.

This revision is now accepted and ready to land.Jul 10 2021, 4:08 PM

349fcda43009d / r335690 landed this change.