bin/dd: Add conv=direct
AbandonedPublic
Actions

Authored by imp on Jun 29 2018, 4:06 PM.

Details

Reviewers

eadler
rpokala
cy
jilles

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17722
Build 17524: arc lint + arc unit

Event Timeline

imp created this revision.Jun 29 2018, 4:06 PM

Harbormaster completed remote builds in B17722: Diff 44641.Jun 29 2018, 4:06 PM

eadler accepted this revision.Jun 29 2018, 4:12 PM

eadler added a subscriber: eadler.

eadler added inline comments.

bin/dd/dd.1
219	s/or/to/

This revision is now accepted and ready to land.Jun 29 2018, 4:12 PM

rpokala accepted this revision.Jun 29 2018, 4:21 PM

I think it might be better to have 3 conv types, IDIRECT, ODIRECT, and DIRECT==IDIRECT|ODIRECT. You may or may not want vm effects on specific files.

bin/dd/dd.1
219	This line reads ok to me, "to eliminate to reduce" would be wrong.

cy accepted this revision.Jun 30 2018, 11:14 PM

NetBSD and GNU instead have iflag= and oflag= operands that accept various open flags such as direct. I think that makes more sense, even though conv=notrunc could be considered to belong with oflag instead (but does not for historical reasons).