mping is a utility for pinging multiple hosts.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sysutils/mping/pkg-descr | ||
|---|---|---|
| 1 ↗ | (On Diff #43990) | pkg-descr should be more descriptive than COMMENT. |
| sysutils/mping/pkg-descr | ||
|---|---|---|
| 4–5 ↗ | (On Diff #44040) | I do not think the FreeBSD ports tree is used on MacOSX or Linux, so the end may not be of any interest here. |
| sysutils/mping/pkg-descr | ||
|---|---|---|
| 4–5 ↗ | (On Diff #44040) | At work we just pick a FreeBSD box and copy it to our mac from that machine. So we use FreeBSD as a means to an end. I don't see anything wrong with that, but if you are intent on removing that bit, I will. |
| sysutils/mping/pkg-descr | ||
|---|---|---|
| 4–5 ↗ | (On Diff #44040) | I don't see anything wrong, I approved the review. I just added a small comment about a bit I felt was not needed. |
Comment Actions
To prevent the "This revision was not accepted when it landed; it landed in state Needs Review." moniker being attached to this review, can you re-approve?
Comment Actions
Derp, you're right. It ended up getting that tag anyway because of bapt's request for changes (which were addressed but bapt didn't come back around to approve). I consider that a short-coming of phabricator that the blocking status of a request for changes doesn't get released when the action is taken. Blah.
Comment Actions
There is a PKGBASE collision between sysutils/mping and net/mping.
PKGNAMEPREFIX or PKGNAMESUFFIX has to be added.
Comment Actions
Been thinking about this for the past day. I can't think of any suitable value for either prefix or suffix. I'm open to suggestions -- perhaps you've delt with this in the past and have a suggestion for suitable value when this occurs.
Comment Actions
I think this is a bug in phabricator. The review was in "closed" state and committed. Then a comment caused it to go back into "Needs Review". The person that added the comment (antoine) even came back and accepted and it still shows as "Needs Review". Can't close this ticket until it is in approved. I'd rather not use the sledgehammer of removing all the reviewers.
Let me reach out to bapt and, imp, and mat to see if their approval can get it out of the "Needs Review" state (which it shouldn't be in because it was previously in "Closed; committed" state prior to comment.