Paths

Table of Contentst

Differential D31416

x86: cpufunc: Add rdtsc_ordered()
ClosedPublic
Actions

Authored by adam_fenn.io on Aug 5 2021, 2:25 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 13, 10:30 PM

	Unknown Object (File)
	Thu, Aug 13, 10:19 PM

	Unknown Object (File)
	Thu, Aug 13, 10:18 PM

	Unknown Object (File)
	Fri, Aug 7, 1:21 PM

	Unknown Object (File)
	Fri, Aug 7, 2:33 AM

	Unknown Object (File)
	Fri, Aug 7, 2:33 AM

	Unknown Object (File)
	Fri, Aug 7, 2:33 AM

	Unknown Object (File)
	Fri, Aug 7, 2:33 AM

Subscribers

Details

Reviewers

kib
markj
stevek
royger

Commits

rG946f96d13b01: x86: cpufunc: Add rdtsc_ordered()
rG652ae7b11485: x86: cpufunc: Add rdtsc_ordered()

Summary

Add a variant of rdtsc() that performs the ordered version of rdtsc
appropriate for the invoking x86 variant.

Test Plan

Tested as part of testing D29733.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40877
Build 37766: arc lint + arc unit

Event Timeline

adam_fenn.io created this revision.Aug 5 2021, 2:25 AM

adam_fenn.io held this revision as a draft.

Herald added subscribers: rpokala, imp. · View Herald TranscriptAug 5 2021, 2:25 AM

Harbormaster completed remote builds in B40860: Diff 93245.Aug 5 2021, 2:25 AM

adam_fenn.io published this revision for review.Aug 5 2021, 2:43 AM

adam_fenn.io added a child revision: D29733: kvmclock driver with vDSO support.

kib added inline comments.Aug 5 2021, 1:43 PM

sys/x86/x86/rdtsc_ordered.c
55	I would add rdtsc_ordered_*fence() functions to cpufunc.h as well.
64	I suppose this branch did not caused a warning from the compiler? I suggest to add {} around the body of the case. Or write it as return (cpu_is_amd ? rdtsc_ordered_mfence : rdtsc_ordered_lfence);

Address @kib's feedback.

Harbormaster completed remote builds in B40877: Diff 93290.Aug 5 2021, 10:47 PM

adam_fenn.io marked 2 inline comments as done.Aug 5 2021, 10:48 PM

kib added inline comments.Aug 5 2021, 11:17 PM

sys/conf/files.x86
322	Drop this file at all.
sys/i386/include/cpufunc.h
850	Move this to x86/include/md_var.h
sys/x86/x86/rdtsc_ordered.c
54	Move this to x86/cpu_machdep.c

Address @kib's feedback.

Harbormaster completed remote builds in B40885: Diff 93309.Aug 6 2021, 5:26 AM

adam_fenn.io marked an inline comment as done.Aug 6 2021, 5:31 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 14 2021, 12:59 PM

Closed by commit rG652ae7b11485: x86: cpufunc: Add rdtsc_ordered() (authored by adam_fenn.io, committed by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG652ae7b11485: x86: cpufunc: Add rdtsc_ordered().

kib added a commit: rG946f96d13b01: x86: cpufunc: Add rdtsc_ordered().Oct 12 2021, 4:03 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

include/

18 lines

conf/

1 line

i386/

include/

18 lines

x86/

x86/

rdtsc_ordered.c

54 lines

Diff 93290

sys/amd64/include/cpufunc.h

Loading...

sys/conf/files.x86

Loading...

sys/i386/include/cpufunc.h

Loading...

sys/x86/x86/rdtsc_ordered.c

Loading...