Differential D58109

fwisound: add Apple FireWire audio driver
ClosedPublic
Actions

Authored by guest-seuros on Wed, Jul 8, 12:56 PM.

Tags

Referenced Files

	F163249290: D58109.id181564.diff
	Tue, Jul 21, 10:09 AM

	F163239560: D58109.id181582.diff
	Tue, Jul 21, 8:18 AM

	Unknown Object (File)
	Wed, Jul 15, 8:32 PM

	Unknown Object (File)
	Wed, Jul 15, 8:52 AM

	Unknown Object (File)
	Wed, Jul 15, 8:23 AM

	Unknown Object (File)
	Wed, Jul 15, 2:09 AM

	Unknown Object (File)
	Tue, Jul 14, 9:36 PM

	Unknown Object (File)
	Tue, Jul 14, 5:33 PM

View All 30 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGcd7b65080f2f: fwisound: add Apple FireWire audio driver

Summary

Expose audio capture from Apple FireWire devices as a standard
pcm(4)/dsp(4) device via the newpcm framework.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 74619
Build 71502: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Wed, Jul 8, 12:56 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptWed, Jul 8, 12:56 PM

guest-seuros requested review of this revision.Wed, Jul 8, 12:56 PM

Harbormaster completed remote builds in B74619: Diff 181537.Wed, Jul 8, 12:56 PM

guest-seuros added a reviewer: firewire.Wed, Jul 8, 1:17 PM

guest-seuros added projects: firewire, drivers.

update Makefile

Harbormaster completed remote builds in B74633: Diff 181564.Wed, Jul 8, 7:04 PM

fix lock on disconnect

Harbormaster completed remote builds in B74636: Diff 181568.Wed, Jul 8, 7:45 PM

adrian accepted this revision.Thu, Jul 9, 12:57 AM

adrian added a parent revision: D58101: fwcam: retry ISO enable after re-powering camera.

This revision is now accepted and ready to land.Thu, Jul 9, 12:57 AM

adrian added a project: audio.Thu, Jul 9, 12:58 AM

adrian added inline comments.

sys/dev/firewire/fwisound.c
397	What's 475 for?

Closed by commit rGcd7b65080f2f: fwisound: add Apple FireWire audio driver (authored by guest-seuros, committed by adrian). · Explain WhyThu, Jul 9, 2:55 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGcd7b65080f2f: fwisound: add Apple FireWire audio driver.

guest-seuros marked an inline comment as done.Thu, Jul 9, 11:54 AM

guest-seuros added inline comments.

sys/dev/firewire/fwisound.c
397	Damn. i should have used a constant #define FWISOUND_MAX_SAMPLES 475 That from Clemens Ladisch's RE: https://github.com/torvalds/linux/blob/29b9667982e4df2ed7744f86b1144f8bb58eb698/sound/firewire/isight.c#L45 The hard upper bound from the packet size would be (2048 - 16) / 4 = 508 . But i didn't want to diverge . We can retry it in another round later with 508 value. (maybe it was a isight firmware in that time, or simply an Apple quirk.

adrian added inline comments.Thu, Jul 9, 2:17 PM

sys/dev/firewire/fwisound.c
397	its ok, just add it to another cleanup diff later. no biggie.

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

1 line

96 lines

sys/

conf/

1 line

2 lines

dev/

firewire/

111 lines

593 lines

235 lines

modules/

firewire/

fwisound/

12 lines

Diff 181537

share/man/man4/Makefile

Loading...

share/man/man4/fwisound.4

Loading...

sys/conf/NOTES

Loading...

sys/conf/files

Loading...

sys/dev/firewire/fwisound.h

Loading...

sys/dev/firewire/fwisound.c

Loading...

sys/dev/firewire/fwisound_pcm.c

Loading...

sys/modules/firewire/fwisound/Makefile

Loading...