Differential D58101

fwcam: retry ISO enable after re-powering camera
ClosedPublic
Actions

Authored by guest-seuros on Wed, Jul 8, 8:25 AM.

Details

Reviewers

adrian

Group Reviewers

firewire

Commits

rGd128ddf32e87: fwcam: retry ISO enable after re-powering camera

Summary

Some IIDC cameras power down the sensor when inactive (e.g. lens
cover closed) and reject ISO enable with EIO. Re-power the camera
and retry once before failing.

Test Plan

Webcam with closed lens should not return an ISO error

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guest-seuros created this revision.Wed, Jul 8, 8:25 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jul 8, 8:25 AM

guest-seuros requested review of this revision.Wed, Jul 8, 8:25 AM

Harbormaster completed remote builds in B74611: Diff 181525.Wed, Jul 8, 8:25 AM

guest-seuros added a reviewer: firewire.Wed, Jul 8, 8:26 AM

guest-seuros added projects: firewire, drivers.

adrian accepted this revision.Thu, Jul 9, 12:56 AM

adrian added a parent revision: D58100: fwcam: defer ISO streaming to first read.

This revision is now accepted and ready to land.Thu, Jul 9, 12:56 AM

adrian added a child revision: D58109: fwisound: add Apple FireWire audio driver.Thu, Jul 9, 12:57 AM

Closed by commit rGd128ddf32e87: fwcam: retry ISO enable after re-powering camera (authored by guest-seuros, committed by adrian). · Explain WhyThu, Jul 9, 2:55 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGd128ddf32e87: fwcam: retry ISO enable after re-powering camera.

Revision Contents
Changeset List

Path

Size

sys/

dev/

firewire/

fwcam.c

17 lines

Diff 181581

View Options

fwcam: retry ISO enable after re-powering cameraClosedPublicActions