Expose audio capture from Apple FireWire devices as a standard
pcm(4)/dsp(4) device via the newpcm framework.
Details
Details
- Reviewers
adrian - Group Reviewers
firewire - Commits
- rGcd7b65080f2f: fwisound: add Apple FireWire audio driver
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 74636 Build 71519: arc lint + arc unit
Event Timeline
| sys/dev/firewire/fwisound.c | ||
|---|---|---|
| 396 | What's 475 for? | |
| sys/dev/firewire/fwisound.c | ||
|---|---|---|
| 396 | Damn. i should have used a constant #define FWISOUND_MAX_SAMPLES 475 That from Clemens Ladisch's RE: https://github.com/torvalds/linux/blob/29b9667982e4df2ed7744f86b1144f8bb58eb698/sound/firewire/isight.c#L45 The hard upper bound from the packet size would be (2048 - 16) / 4 = 508 . But i didn't want to diverge . We can retry it in another round later with 508 value. (maybe it was a isight firmware in that time, or simply an Apple quirk. | |
| sys/dev/firewire/fwisound.c | ||
|---|---|---|
| 396 | its ok, just add it to another cleanup diff later. no biggie. | |