Page MenuHomeFreeBSD
Differential D54073

bhyve/virtio-scsi: Make all I/O processing parameters configurable
ClosedPublic
Actions

Authored by rosenfeld_grumpf.hope-2000.org on Dec 4 2025, 6:51 PM.
Tags
None
Referenced Files
F172269738: D54073.id172279.diff
Thu, Sep 17, 9:33 AM
Unknown Object (File)
Fri, Sep 11, 7:01 AM
Unknown Object (File)
Thu, Sep 10, 9:54 PM
Unknown Object (File)
Wed, Sep 9, 7:45 PM
Unknown Object (File)
Tue, Sep 8, 11:51 PM
Unknown Object (File)
Tue, Sep 8, 10:39 PM
Unknown Object (File)
Tue, Sep 8, 7:07 PM
Unknown Object (File)
Tue, Sep 8, 6:28 PM
View All Files
Subscribers
bcran
imp
novel
rgrimes
ziaee

Details

Reviewers
jhb
markj
corvink
Group Reviewers
bhyve
Commits
rGccb14be785f7: bhyve/virtio-scsi: Make all I/O processing parameters configurable
Summary

This includes:

  • seg_max, the number of segments allowed in a single command
  • {ctl,evt,req}_ringsz, the number of descriptors in a queue
  • thr_per_q, the number of processing threads per request queue
  • num_queues, the number of request queues

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72044
Build 68927: arc lint + arc unit

Event Timeline

rosenfeld_grumpf.hope-2000.org created this revision.Dec 4 2025, 6:51 PM
Herald added subscribers: ziaee, bcran, rgrimes, imp. · View Herald TranscriptDec 4 2025, 6:51 PM
rosenfeld_grumpf.hope-2000.org requested review of this revision.Dec 4 2025, 6:51 PM
Harbormaster completed remote builds in B69052: Diff 167548.Dec 4 2025, 6:51 PM
rosenfeld_grumpf.hope-2000.org retitled this revision from bhyve/virtio-scsi: make all I/O processing parameters configurable to bhyve/virtio-scsi: Make all I/O processing parameters configurable.Feb 19 2026, 7:37 PM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 172279.Feb 19 2026, 7:38 PM

Rebase.

Harbormaster completed remote builds in B70799: Diff 172279.Feb 19 2026, 7:38 PM
markj accepted this revision as: markj.Feb 22 2026, 5:30 PM
markj added inline comments.
usr.sbin/bhyve/bhyve.8
745
This revision is now accepted and ready to land.Feb 22 2026, 5:30 PM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 173629.Mar 12 2026, 8:34 PM
rosenfeld_grumpf.hope-2000.org marked an inline comment as done.

Review from markj.

This revision now requires review to proceed.Mar 12 2026, 8:34 PM
Harbormaster completed remote builds in B71372: Diff 173629.Mar 12 2026, 8:34 PM
markj accepted this revision as: markj.Mar 14 2026, 3:06 AM
This revision is now accepted and ready to land.Mar 14 2026, 3:06 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 173686.Mar 14 2026, 11:07 AM

Rebase.

This revision now requires review to proceed.Mar 14 2026, 11:07 AM
Harbormaster completed remote builds in B71402: Diff 173686.Mar 14 2026, 11:07 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 173749.Mar 16 2026, 8:38 AM

Garbage-collect a comment obsoleted by this change.

Harbormaster completed remote builds in B71426: Diff 173749.Mar 16 2026, 8:38 AM
markj accepted this revision as: markj.Mar 20 2026, 2:22 AM
This revision is now accepted and ready to land.Mar 20 2026, 2:22 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 175089.Apr 8 2026, 10:55 AM

Rebase.

This revision now requires review to proceed.Apr 8 2026, 10:55 AM
Harbormaster completed remote builds in B72044: Diff 175089.Apr 8 2026, 10:55 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 175972.Apr 21 2026, 10:43 AM

Rebase.

Harbormaster completed remote builds in B72408: Diff 175972.Apr 21 2026, 10:43 AM
novel added a subscriber: novel.May 16 2026, 9:15 AM
markj added inline comments.May 17 2026, 10:44 PM
usr.sbin/bhyve/pci_virtio_scsi.c
919

I think this stack allocation can be quite large. Is there some reason not to do a heap allocation here, given that this is the control queue?

1467

sc->vss_queues can be NULL here.

rosenfeld_grumpf.hope-2000.org updated this revision to Diff 178582.May 25 2026, 8:42 PM
rosenfeld_grumpf.hope-2000.org marked 2 inline comments as done.

Review from markj.

Harbormaster completed remote builds in B73437: Diff 178582.May 25 2026, 8:42 PM
markj accepted this revision as: markj.May 26 2026, 1:33 AM
markj added inline comments.
usr.sbin/bhyve/pci_virtio_scsi.c
919
This revision is now accepted and ready to land.May 26 2026, 1:33 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 178595.May 26 2026, 7:26 AM

Review from markj.

This revision now requires review to proceed.May 26 2026, 7:26 AM
Harbormaster completed remote builds in B73442: Diff 178595.May 26 2026, 7:26 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 26 2026, 4:07 PM
Closed by commit rGccb14be785f7: bhyve/virtio-scsi: Make all I/O processing parameters configurable (authored by rosenfeld_grumpf.hope-2000.org, committed by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGccb14be785f7: bhyve/virtio-scsi: Make all I/O processing parameters configurable.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
12 lines
16 lines
80 lines
217 lines

Diff 175089

View Options

usr.sbin/bhyve/bhyve.8

Loading...
View Options

usr.sbin/bhyve/bhyve_config.5

Loading...
View Options

usr.sbin/bhyve/pci_virtio_scsi.h

Loading...
View Options

usr.sbin/bhyve/pci_virtio_scsi.c

Loading...