Page MenuHomeFreeBSD
Differential D53403

resource_list_reserve: Pass rid by value
ClosedPublic
Actions

Authored by jhb on Oct 28 2025, 5:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 17, 10:34 AM
Unknown Object (File)
Sun, May 17, 10:34 AM
Unknown Object (File)
Sat, May 16, 11:48 PM
Unknown Object (File)
Sat, May 16, 6:16 PM
Unknown Object (File)
Thu, May 14, 6:51 PM
Unknown Object (File)
Thu, May 14, 6:51 PM
Unknown Object (File)
Thu, May 14, 6:51 PM
Unknown Object (File)
Thu, May 14, 6:51 PM
View All 51 Files
Subscribers
dsl
olce

Details

Reviewers
imp
Commits
rGe279724ae5a7: resource_list_reserve: Pass rid by value

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Oct 28 2025, 5:17 PM
Herald added a subscriber: olce. · View Herald TranscriptOct 28 2025, 5:17 PM
jhb requested review of this revision.Oct 28 2025, 5:17 PM
Herald added a subscriber: dsl. · View Herald TranscriptOct 28 2025, 5:17 PM
jhb added a parent revision: D53402: bus_alloc_resource: Pass rid by value to BUS_ALLOC_RESOURCE DEVMETHOD.Oct 28 2025, 5:17 PM
Harbormaster completed remote builds in B68172: Diff 165221.Oct 28 2025, 5:17 PM
jhb added a child revision: D53404: pci_reserve_map: Pass rid by value.Oct 28 2025, 5:17 PM
imp accepted this revision.Oct 29 2025, 5:31 PM

These changes look good. Since we never wound up changing the RIDs, this is good. Doug had originally thought we would, but I guess a use case never materalized... or it died when we killed the Alpha or Sparc ports.

sys/dev/pci/pci.c
3575

Oh! My! We're still doing that for old-old-old school ATA PCI devices... Fun times.

This revision is now accepted and ready to land.Oct 29 2025, 5:31 PM
Closed by commit rGe279724ae5a7: resource_list_reserve: Pass rid by value (authored by jhb). · Explain WhyDec 9 2025, 8:12 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGe279724ae5a7: resource_list_reserve: Pass rid by value.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
2 lines
dpaa2/
2 lines
pci/
23 lines
kern/
6 lines
sys/
2 lines

Diff 167789

View Options

sys/dev/acpica/acpi.c

Loading...
View Options

sys/dev/dpaa2/dpaa2_rc.c

Loading...
View Options

sys/dev/pci/pci.c

Loading...
View Options

sys/kern/subr_bus.c

Loading...
View Options

sys/sys/bus.h

Loading...