bus_alloc_resource: First step in passing resource IDs by value
ClosedPublic
Actions

Authored by jhb on Tue, Oct 28, 5:17 PM.

Details

Reviewers

imp

Commits

rG7eb213614b90: bus_alloc_resource: First step in passing resource IDs by value

Summary

Add wrapper inline functions for bus_alloc_resource* that accept a
resource ID by value (instead of a pointer). The rest of the bus
resource API (outside of compat shims) does not accept resource IDs as
arguments, but instead obtains the resource ID from the resource
itself when needed. As such, there is no reason to return any
potentially modified resource IDs to the caller.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Tue, Oct 28, 5:17 PM

Herald added subscribers: ziaee, olce. · View Herald TranscriptTue, Oct 28, 5:17 PM

jhb requested review of this revision.Tue, Oct 28, 5:17 PM

Harbormaster completed remote builds in B68170: Diff 165219.Tue, Oct 28, 5:17 PM

jhb added a child revision: D53402: bus_alloc_resource: Pass rid by value to BUS_ALLOC_RESOURCE DEVMETHOD.Tue, Oct 28, 5:17 PM

This will also need a __FreeBSD_version bump. I intend to merge this back to the stable branches that support the newer bus_release_resource such as stable/14 and stable/15.

Nice transition work with _Generic.

sys/sys/bus.h
644	Do we want to mark this for removal in 16 sometime?

This revision is now accepted and ready to land.Tue, Oct 28, 10:40 PM

jhb added inline comments.Wed, Oct 29, 12:18 PM

sys/sys/bus.h
644	There's not a good way to mark it. I plan to remove the earlier compat shims below this in 16 and when fixing drivers to stop passing type/rid to the other functions, I will probably fix them for this change at the same time, so probably I will be able to remove then.