Differential D53410

bhnd_bus_*_resource: Remove redundant type and rid arguments
ClosedPublic
Actions

Authored by jhb on Oct 28 2025, 5:18 PM.

Tags

None

Referenced Files

	F163109367: D53410.id165228.diff
	Mon, Jul 20, 3:53 AM

	Unknown Object (File)
	Sat, Jul 18, 9:57 PM

	Unknown Object (File)
	Fri, Jul 17, 7:11 PM

	Unknown Object (File)
	Wed, Jul 15, 6:52 AM

	Unknown Object (File)
	Wed, Jul 15, 6:52 AM

	Unknown Object (File)
	Sun, Jul 12, 9:07 PM

	Unknown Object (File)
	Sat, Jul 4, 11:26 AM

	Unknown Object (File)
	Sat, Jul 4, 2:10 AM

View All 69 Files

Subscribers

None

Details

Reviewers

Commits

rGca942ab4b2b6: bhnd_bus_*_resource: Remove redundant type and rid arguments

Summary

Remove type and rid arguments from
bhnd_bus_(activate|deactivate|release)_resource. This should have
been done earlier to match the changes made to bus_release_resource,
etc.

While fixing up the callers, remove rid members from softc structures
since the only time a value is needed is as a constant input to
bhnd_bus_alloc_resource*.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Oct 28 2025, 5:18 PM

jhb created this revision.

Harbormaster completed remote builds in B68179: Diff 165228.Oct 28 2025, 5:18 PM

jhb added a parent revision: D53409: bhnd_bus_alloc_resource*: Pass rid by value.Oct 28 2025, 5:18 PM

imp accepted this revision.Oct 29 2025, 5:37 PM

This revision is now accepted and ready to land.Oct 29 2025, 5:37 PM

Closed by commit rGca942ab4b2b6: bhnd_bus_*_resource: Remove redundant type and rid arguments (authored by jhb). · Explain WhyDec 9 2025, 8:13 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGca942ab4b2b6: bhnd_bus_*_resource: Remove redundant type and rid arguments.

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

bcma/

10 lines

1 line

33 lines

6 lines

14 lines

20 lines

bhndb/

10 lines

cores/

chipc/

9 lines

8 lines

chipc_gpiovar.h

1 line

chipc_private.h

1 line

16 lines

pci/

4 lines

1 line

pcie2/

4 lines

bhnd_pcie2_var.h

1 line

pmu/

bhnd_pmu_core.c

9 lines

1 line

nvram/

8 lines

siba/

6 lines

5 lines

1 line

Diff 167796

sys/dev/bhnd/bcma/bcma_subr.c

Loading...

sys/dev/bhnd/bcma/bcmavar.h

Loading...

sys/dev/bhnd/bhnd.h

Loading...

sys/dev/bhnd/bhnd_bus_if.m

Loading...

sys/dev/bhnd/bhnd_erom.c

Loading...

sys/dev/bhnd/bhnd_subr.c

Loading...

sys/dev/bhnd/bhndb/bhndb.c

Loading...

sys/dev/bhnd/cores/chipc/chipc.c

Loading...

sys/dev/bhnd/cores/chipc/chipc_gpio.c

Loading...

sys/dev/bhnd/cores/chipc/chipc_gpiovar.h

Loading...

sys/dev/bhnd/cores/chipc/chipc_private.h

Loading...

sys/dev/bhnd/cores/chipc/chipc_subr.c

Loading...

sys/dev/bhnd/cores/pci/bhnd_pci.c

Loading...

sys/dev/bhnd/cores/pci/bhnd_pcivar.h

Loading...

sys/dev/bhnd/cores/pcie2/bhnd_pcie2.c

Loading...

sys/dev/bhnd/cores/pcie2/bhnd_pcie2_var.h

Loading...

sys/dev/bhnd/cores/pmu/bhnd_pmu_core.c

Loading...

sys/dev/bhnd/cores/pmu/bhnd_pmuvar.h

Loading...

sys/dev/bhnd/nvram/bhnd_sprom.c

Loading...

sys/dev/bhnd/siba/siba.c

Loading...

sys/dev/bhnd/siba/siba_subr.c

Loading...

sys/dev/bhnd/siba/sibavar.h

Loading...