WIP: dtrace_mib.4: Document the DTrace MIB provider
Needs ReviewPublic
Actions

Authored by 0mp on Wed, Nov 12, 2:56 PM.

Details

Reviewers

gnn
kp

Summary

Obtained from: 60d8dbbef075 netinet: add a probe point for IP, IP6, ICMP, ICMP6, UDP and TCP stats counters

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68572
Build 65455: arc lint + arc unit

Event Timeline

0mp created this revision.Wed, Nov 12, 2:56 PM

Herald added a reviewer: gnn. · View Herald TranscriptWed, Nov 12, 2:56 PM

Herald added subscribers: ziaee, imp. · View Herald Transcript

0mp requested review of this revision.Wed, Nov 12, 2:56 PM

Harbormaster completed remote builds in B68572: Diff 166299.Wed, Nov 12, 2:56 PM

0mp added a reviewer: kp.Thu, Nov 13, 10:30 AM

The content looks good to me.

I don't know if it's worth mentioning that there are a handful of probes that have a second argument. Things like icp6_outhist are actually arrays of different ICMP6 types, and we allow the type to be probed as well.

This revision is now accepted and ready to land.Thu, Nov 13, 10:46 AM

Thanks @kp!

Here are some updates:

Cross-reference dtrace_mib(4)
Clarify what ah and esp are
Mention that some probes provide more than 1 argument. I think it's helpful to note that so that users can explore from here.
I need to double-check the part where I recommend against using typed args[]. I just don't remember anymore if that's true.

This revision now requires review to proceed.Thu, Nov 13, 6:50 PM

Harbormaster completed remote builds in B68616: Diff 166384.Thu, Nov 13, 6:50 PM

0mp added subscribers: tuexen, markj, gallatin.Thu, Nov 13, 6:58 PM