Page MenuHomeFreeBSD
Differential D53223

bhyve/virtio-scsi: Support multiple backends
ClosedPublic
Actions

Authored by rosenfeld_grumpf.hope-2000.org on Oct 20 2025, 5:46 PM.
Tags
None
Referenced Files
F163541760: D53223.id175088.diff
Fri, Jul 24, 7:26 AM
Unknown Object (File)
Thu, Jul 23, 7:23 AM
Unknown Object (File)
Thu, Jul 23, 6:33 AM
Unknown Object (File)
Thu, Jul 23, 3:29 AM
Unknown Object (File)
Thu, Jul 23, 2:57 AM
Unknown Object (File)
Thu, Jul 23, 2:14 AM
Unknown Object (File)
Wed, Jul 22, 3:43 PM
Unknown Object (File)
Tue, Jul 21, 8:23 PM
View All Files
Subscribers
bcran
imp
rgrimes
ziaee

Details

Reviewers
jhb
corvink
markj
Group Reviewers
bhyve
Commits
rG9542ddb21dc1: bhyve/virtio-scsi: Support multiple backends
Summary

In order to support multiple backends for virtio-scsi, we should isolate
the core of virtio-scsi from the backend-specific code. The existing
interface to CTL will become the new "CTL" backend for virtio-scsi.

Care has been taken to keep compatibility with previous configurations:
The first backend linked (CTL) will be the default backend if none is
specified, and it does provide a default configuration if no further
options such as targets are explicitly configured.

This is currently also under review in illumos: https://code.illumos.org/c/illumos-gate/+/4425

If you're curious about what another backend does look like, here's the review for the illumos USCSI(4i) backend for SCSI passthrough: https://code.illumos.org/c/illumos-gate/+/4426

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67944
Build 64827: arc lint + arc unit

Event Timeline

rosenfeld_grumpf.hope-2000.org created this revision.Oct 20 2025, 5:46 PM
Herald added a reviewer: bhyve. · View Herald TranscriptOct 20 2025, 5:46 PM
Herald added subscribers: ziaee, bcran, rgrimes, imp. · View Herald Transcript
rosenfeld_grumpf.hope-2000.org requested review of this revision.Oct 20 2025, 5:46 PM
Harbormaster completed remote builds in B67944: Diff 164636.Oct 20 2025, 5:46 PM
rosenfeld_grumpf.hope-2000.org added a parent revision: D53222: bhyve/virtio-scsi: Implement task management functions.Oct 20 2025, 5:46 PM
rosenfeld_grumpf.hope-2000.org edited the summary of this revision. (Show Details)Oct 20 2025, 7:35 PM
rosenfeld_grumpf.hope-2000.org mentioned this in D53220: bhyve/virtio-scsi: various small improvements.Oct 21 2025, 9:38 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 165407.Oct 30 2025, 7:57 AM

Rebase.

Harbormaster completed remote builds in B68271: Diff 165407.Oct 30 2025, 7:57 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 165415.Oct 30 2025, 8:28 AM

Rebase.

Harbormaster completed remote builds in B68277: Diff 165415.Oct 30 2025, 8:28 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 167546.Dec 4 2025, 6:34 PM

Minor updates.

Harbormaster completed remote builds in B69051: Diff 167546.Dec 4 2025, 6:34 PM
rosenfeld_grumpf.hope-2000.org retitled this revision from bhyve/virtio-scsi: support multiple backends to bhyve/virtio-scsi: Support multiple backends.Feb 19 2026, 7:36 PM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 172278.Feb 19 2026, 7:37 PM

Rebase.

Harbormaster completed remote builds in B70798: Diff 172278.Feb 19 2026, 7:37 PM
markj accepted this revision as: markj.Feb 22 2026, 5:24 PM
markj added inline comments.
usr.sbin/bhyve/pci_virtio_scsi_ctl.c
173

Same style issue below.

This revision is now accepted and ready to land.Feb 22 2026, 5:24 PM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 173628.Mar 12 2026, 8:34 PM
rosenfeld_grumpf.hope-2000.org marked an inline comment as done.

Review from markj.

This revision now requires review to proceed.Mar 12 2026, 8:34 PM
Harbormaster completed remote builds in B71371: Diff 173628.Mar 12 2026, 8:34 PM
markj accepted this revision as: markj.Mar 14 2026, 3:05 AM
This revision is now accepted and ready to land.Mar 14 2026, 3:05 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 173685.Mar 14 2026, 11:07 AM

Rebase.

This revision now requires review to proceed.Mar 14 2026, 11:07 AM
Harbormaster completed remote builds in B71401: Diff 173685.Mar 14 2026, 11:07 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 175088.Apr 8 2026, 10:55 AM

Rebase.

Harbormaster completed remote builds in B72043: Diff 175088.Apr 8 2026, 10:55 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 175971.Apr 21 2026, 10:42 AM

Rebase.

Harbormaster completed remote builds in B72407: Diff 175971.Apr 21 2026, 10:42 AM
markj added inline comments.May 17 2026, 10:45 PM
usr.sbin/bhyve/pci_virtio_scsi_ctl.c
145

This will do the wrong thing if nvl == NULL.

176

I guess this should be sc->vss_backend?

rosenfeld_grumpf.hope-2000.org updated this revision to Diff 178581.May 25 2026, 8:41 PM
rosenfeld_grumpf.hope-2000.org marked an inline comment as done.

Review from markj.

Harbormaster completed remote builds in B73436: Diff 178581.May 25 2026, 8:41 PM
rosenfeld_grumpf.hope-2000.org added inline comments.May 25 2026, 8:43 PM
usr.sbin/bhyve/pci_virtio_scsi_ctl.c
145

It should never be NULL as the "target" node is always created before this is called. I replaced the NULL check above with an assertion to that effect.

markj accepted this revision as: markj.May 26 2026, 1:49 AM
markj added inline comments.
usr.sbin/bhyve/pci_virtio_scsi_ctl.c
150
This revision is now accepted and ready to land.May 26 2026, 1:49 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 178594.May 26 2026, 7:24 AM
rosenfeld_grumpf.hope-2000.org marked an inline comment as done.

Review from markj.

This revision now requires review to proceed.May 26 2026, 7:24 AM
Harbormaster completed remote builds in B73441: Diff 178594.May 26 2026, 7:24 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 26 2026, 4:07 PM
Closed by commit rG9542ddb21dc1: bhyve/virtio-scsi: Support multiple backends (authored by rosenfeld_grumpf.hope-2000.org, committed by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG9542ddb21dc1: bhyve/virtio-scsi: Support multiple backends.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
1 line
44 lines
26 lines
291 lines
531 lines
374 lines

Diff 164636

View Options

usr.sbin/bhyve/Makefile

Loading...
View Options

usr.sbin/bhyve/bhyve.8

Loading...
View Options

usr.sbin/bhyve/bhyve_config.5

Loading...
View Options

usr.sbin/bhyve/pci_virtio_scsi.h

Loading...
View Options

usr.sbin/bhyve/pci_virtio_scsi.c

Loading...
View Options

usr.sbin/bhyve/pci_virtio_scsi_ctl.c

Loading...