linuxkpi: Support s2idle in `pm_suspend_target_state`
ClosedPublic
Actions

Authored by obiwac on Jul 28 2025, 11:45 AM.

Details

Reviewers

dumbbell
bz

Group Reviewers

cam

Commits

rGa25cfcab9a9d: linuxkpi: Support s2idle in `pm_suspend_target_state`

Summary

Add enum sleep_type stype parameter in power_suspend/resume event
handlers, as with the introduction of s2idle there are more than one
type of suspend.

When going to s2idle, set Linux' pm_suspend_target_state to
PM_SUSPEND_TO_IDLE instead of setting PM_SUSPEND_MEM (for S3) in all
cases. This is necessary because more recent versions of the amdgpu DRM
drivers have different paths for when entering s2idle & S0ix is
supported than S3.

Event: EuroBSDcon Devsummit 2025
Sponsored by: The FreeBSD Foundation

Test Plan

Works on AMD Framework 7040 (i.e. S0i3 is being entered correctly with these changes).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 67275
Build 64158: arc lint + arc unit

Event Timeline

obiwac created this revision.Jul 28 2025, 11:45 AM

Herald added a reviewer: cam. · View Herald TranscriptJul 28 2025, 11:45 AM

Herald added subscribers: linuxkpi, ehem_freebsd_m5p.com, dab and 2 others. · View Herald Transcript

obiwac requested review of this revision.Jul 28 2025, 11:45 AM

Harbormaster completed remote builds in B65794: Diff 159278.Jul 28 2025, 11:45 AM

I would like to make enum sleep_type (currently defined in dev/acpica/acpivar.h) generic so that it can be used on non-ACPI systems and everywhere the event handlers using power_change_fn are being used. Not 100% sure where to put this just yet though, and this needs to be changed in D48732.

obiwac added a parent revision: D48732: acpi: Abstract over ACPI Sx sleep states with `enum sleep_type`.Jul 28 2025, 11:47 AM

obiwac edited parent revisions, added: D48734: acpi: Suspend-to-idle support (s2idle); removed: D48732: acpi: Abstract over ACPI Sx sleep states with `enum sleep_type`.

obiwac edited the summary of this revision. (Show Details)Jul 28 2025, 11:58 AM

obiwac edited the summary of this revision. (Show Details)Jul 28 2025, 12:14 PM

No newbus integration?

In D51591#1178545, @imp wrote:

No newbus integration?

What kind of integration would you like to see with newbus? Maybe I don't understand your comment.

obiwac mentioned this in D48732: acpi: Abstract over ACPI Sx sleep states with `enum sleep_type`.Jul 30 2025, 9:49 PM

D52036 does the work of making sleep types generic. One that design gets the go-ahead, I will update this revision to base on top of that.

obiwac edited the summary of this revision. (Show Details)Wed, Sep 24, 12:12 PM

obiwac edited the summary of this revision. (Show Details)

Rebase on top of D52705.

Harbormaster completed remote builds in B67275: Diff 162725.Wed, Sep 24, 12:18 PM

obiwac added a parent revision: D52705: acpi: Use sleep types defined in sys/power.h.Wed, Sep 24, 12:18 PM

obiwac added a reviewer: bz.Wed, Sep 24, 1:33 PM

This in general seems not to be specific to linuxkpi so maybe the title would be better to mention the eventhandler KPI update (of which linuxkpi seems to be one consumer).

I might go as far as splitting this into (a) the general event handler update and (b) improving linuxkpi?

Either way I am fine with the code changes.

I cannot comment on amdgpu, so @dumbbell could check that but if you are on a framework I assume you have tested this first hand, so...

This revision is now accepted and ready to land.Sat, Oct 4, 3:14 PM