Differential D50747

run: enable seqno offload
Needs ReviewPublic
Actions

Authored by adrian on Jun 9 2025, 2:13 AM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Aug 14, 10:44 PM

	Unknown Object (File)
	Mon, Aug 4, 9:51 AM

	Unknown Object (File)
	Fri, Aug 1, 6:22 PM

	Unknown Object (File)
	Fri, Aug 1, 6:12 PM

	Unknown Object (File)
	Sat, Jul 26, 6:13 AM

	Unknown Object (File)
	Jul 20 2025, 8:16 AM

	Unknown Object (File)
	Jul 18 2025, 11:51 AM

	Unknown Object (File)
	Jul 7 2025, 5:51 AM

View All 28 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Summary

Enable sequence number offload.

This should both enable the sequence number offloading and disable
the net80211 TX lock from being acquired/released/checked.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64715
Build 61599: arc lint + arc unit

Event Timeline

adrian created this revision.Jun 9 2025, 2:13 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 9 2025, 2:13 AM

adrian requested review of this revision.Jun 9 2025, 2:13 AM

Harbormaster completed remote builds in B64715: Diff 156697.Jun 9 2025, 2:13 AM

adrian added a child revision: D50748: rsu: implement A-MPDU TX; add TODO items for further work.Jun 9 2025, 2:13 AM

adrian added a parent revision: D50694: iwx: enable seqno offload.

adrian added a child revision: D50749: rsu: enable seqno offload.

adrian removed a child revision: D50748: rsu: implement A-MPDU TX; add TODO items for further work.

adrian added a reviewer: wireless.Jun 9 2025, 2:18 AM

adrian added a project: wireless.

I know not much about tun internals; it looks okay but you need to know and test.

On 2nd though, nothing guards against ieee80211_output_seqno_assign() being called twice. Can we be sure net80211 in no case has a seq# assigned to wh? Or should ieee80211_output_seqno_assign() assert that if tid_arg is -1 that tid from from the frame is 0?

I just leave this comment here; it came to my mind based on the next review; I also think we should carefully define what IEEE80211_FEXT_SEQNO_OFFLOAD means with a comment in net80211 as it does not necessarily mean hardware offload like others but could also mean driver offload?

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

wlan/

14 lines

Diff 156697

sys/dev/usb/wlan/if_run.c

Loading...