Page MenuHomeFreeBSD

netlink: some refactoring of NETLINK_GENERIC layer
ClosedPublic

Authored by glebius on Jan 3 2025, 10:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 8, 5:39 PM
Unknown Object (File)
Tue, Apr 7, 10:00 AM
Unknown Object (File)
Tue, Apr 7, 1:06 AM
Unknown Object (File)
Thu, Apr 2, 1:31 PM
Unknown Object (File)
Wed, Apr 1, 5:57 AM
Unknown Object (File)
Thu, Mar 26, 9:32 PM
Unknown Object (File)
Thu, Mar 26, 2:05 PM
Unknown Object (File)
Thu, Mar 26, 1:50 PM
Subscribers

Details

Summary
  • Statically initialize control family/group. This removes extra startup

code and provides a strong guarantee that they reside at the 0 index of
the respective arrays. Before a genl_register_family() with a higher
SYSINIT order could try to hijack index 0.

  • Remove the family_id field completely. Now the family ID as well as

group ID are array indices and there is basically no place for a mistake.
Previous code had a bug where a KPI user could induce an ID mismatch.

  • Merge netlink_generic_kpi.c to netlink_generic.c. Both files are small

and now there is more dependency between the control family and the family
allocator. Ok'ed by melifaro@.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable