Page MenuHomeFreeBSD
Differential D48030

Makefile.inc1: Require DISTDIR be set for `make distributeworld`
ClosedPublic
Actions

Authored by emaste on Dec 11 2024, 3:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 1:42 AM
Unknown Object (File)
Mar 12 2025, 5:22 PM
Unknown Object (File)
Mar 10 2025, 5:22 PM
Unknown Object (File)
Mar 5 2025, 3:21 PM
Unknown Object (File)
Mar 5 2025, 4:44 AM
Unknown Object (File)
Mar 2 2025, 1:01 PM
Unknown Object (File)
Feb 28 2025, 5:13 PM
Unknown Object (File)
Feb 13 2025, 7:17 PM
View All 17 Files
Subscribers
None

Details

Reviewers
imp
brooks
Group Reviewers
releng
Commits
rG6d1d5577ce10: Makefile.inc1: Require DISTDIR be set for `make distributeworld`
rGf6575ed0deb0: Makefile.inc1: Require DISTDIR be set for `make distributeworld`
Summary
distributeworld is the target used to stage world for building dist sets
for release targets.  Error out if attempting to distributeworld to /.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Dec 11 2024, 3:56 PM
emaste created this revision.
emaste added a reviewer: brooks.Dec 12 2024, 5:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 13 2024, 3:24 PM
Closed by commit rGf6575ed0deb0: Makefile.inc1: Require DISTDIR be set for `make distributeworld` (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGf6575ed0deb0: Makefile.inc1: Require DISTDIR be set for `make distributeworld`.
brooks added a comment.Dec 13 2024, 5:28 PM

This seems like a good change. I have some vague memories about complaints when I changed things in this area, but I think that might have been the largely unrelated "distribution" target.

imp added a comment.Dec 13 2024, 5:57 PM

Yes. Good change. I've shot my foot off this way

emaste added a commit: rG6d1d5577ce10: Makefile.inc1: Require DISTDIR be set for `make distributeworld`.Dec 16 2024, 12:40 AM

Revision Contents
Changeset List

PathSize
3 lines

Diff 147924

View Options

Makefile.inc1

# $FreeBSD$ # $FreeBSD$
HPTNR= ${SRCTOP}/sys/dev/hptnr HPTNR= ${SRCTOP}/sys/dev/hptnr
.PATH: ${HPTNR} .PATH: ${HPTNR}
KMOD= hptnr KMOD= hptnr
SRCS= bus_if.h device_if.h pci_if.h SRCS= bus_if.h device_if.h pci_if.h
SRCS+= opt_cam.h opt_scsi.h SRCS+= opt_cam.h opt_scsi.h
SRCS+= os_bsd.h hptnr_os_bsd.c hptnr_osm_bsd.c hptnr_config.c SRCS+= os_bsd.h hptnr_os_bsd.c hptnr_osm_bsd.c hptnr_config.c
OBJS+= hptnr_lib.o OBJS+= ${HPTNR}/${MACHINE_ARCH}-elf.hptnr_lib.o
hptnr_lib.o:
uudecode -p < ${HPTNR}/${MACHINE_ARCH}-elf.hptnr_lib.o.uu > ${.TARGET}
emasteUnsubmitted
Done
Inline Actions

Can we just do OBJS+=${MACHINE_ARCH}-elf.hptnr_lib.o?

emaste: Can we just do `OBJS+=${MACHINE_ARCH}-elf.hptnr_lib.o`?
impAuthorUnsubmitted
Done
Inline Actions

${.SRCDIR} vs ${.OBJDIR} issues? I've not checked on this detail, though.

imp: ${.SRCDIR} vs ${.OBJDIR} issues? I've not checked on this detail, though.
.include <bsd.kmod.mk> .include <bsd.kmod.mk>