Page MenuHomeFreeBSD

iwm: Stop shipping firmware as kernel module
ClosedPublic

Authored by manu on Dec 12 2024, 4:21 PM.
Tags
None
Referenced Files
F107886772: D48057.id147872.diff
Sun, Jan 19, 12:57 AM
Unknown Object (File)
Wed, Jan 8, 11:41 AM
Unknown Object (File)
Wed, Jan 8, 3:58 AM
Unknown Object (File)
Wed, Jan 8, 3:34 AM
Unknown Object (File)
Wed, Jan 8, 1:13 AM
Unknown Object (File)
Fri, Dec 27, 11:24 AM
Unknown Object (File)
Thu, Dec 26, 8:45 AM
Unknown Object (File)
Sun, Dec 22, 5:03 PM

Details

Reviewers
imp
emaste
cy
adrian
manu
Group Reviewers
wireless
Summary

Since we can load raw firmware start shipping them as is.
This also remove the uuencode format that don't add any value.
For pkgbase users they are now in the FreeBSD-firmware-iwm package.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61139
Build 58023: arc lint + arc unit

Event Timeline

manu requested review of this revision.Dec 12 2024, 4:21 PM
cy added a subscriber: cy.

This would be welcome.

This revision is now accepted and ready to land.Dec 12 2024, 5:45 PM
adrian added a subscriber: adrian.

oh neat, iwm can load the firmware directly now? yes please.

oh neat, iwm can load the firmware directly now? yes please.

Yes this just work for me, it tries loading the .ko first I think but I'll have a look at this before committing this (and hopefully will have a patch for that).

Garbage collect the old firmwares.

This revision now requires review to proceed.Dec 13 2024, 9:24 AM

Will we (or how about directly) move them to wifi-firmware- ports?

Will we (or how about directly) move them to wifi-firmware- ports?

That's not my plan no, since we're moving toward pkgbase users will have a way to install them or not, moving them to ports gives us nothing.

Will we (or how about directly) move them to wifi-firmware- ports?

That's not my plan no, since we're moving toward pkgbase users will have a way to install them or not, moving them to ports gives us nothing.

How will buildworld users install the firmware then?

In D48057#1095862, @cy wrote:

Will we (or how about directly) move them to wifi-firmware- ports?

That's not my plan no, since we're moving toward pkgbase users will have a way to install them or not, moving them to ports gives us nothing.

How will buildworld users install the firmware then?

installworld (moved from installkernel as it's no longer per-kernel)

In D48057#1095862, @cy wrote:

Will we (or how about directly) move them to wifi-firmware- ports?

That's not my plan no, since we're moving toward pkgbase users will have a way to install them or not, moving them to ports gives us nothing.

How will buildworld users install the firmware then?

installworld (moved from installkernel as it's no longer per-kernel)

Correct, maybe if we start shipping a lot of raw firmware we could add a installfirmware (that would be part of installworld or not) but for now I don't see the point.

This revision is now accepted and ready to land.Dec 16 2024, 9:51 AM

Will we (or how about directly) move them to wifi-firmware- ports?

That's not my plan no, since we're moving toward pkgbase users will have a way to install them or not, moving them to ports gives us nothing.

That's not true; they vanish from src and make the checkout smaller. Your argument for a year of pain for me you now ignored yourself.