Differential D46719
libkldelf: add a private library for kernel/kld-related ELF parsing Authored by khng on Sep 20 2024, 4:55 PM. Tags None Referenced Files
Details The libkldelf library was originally a part of kldxref(8). It exposed To promote the reuse of the facilities the ELF parsing code is separated kldxref(8) is modified to link against the libkldelf library. Sponsored by: Juniper Networks, Inc.
Diff Detail
Event TimelineComment Actions I think it would be easier to review if you moved the files out of kldxref and changed kldxref to use the library as part of this commit. Git might be able to follow history in that case, but with simple copies it is not coping it seems. Comment Actions This is missing some description of libkldelf's intended functionality, either in the commit message or in a man page (maybe a man page is not required for private libraries). It's hard to tell at a glance what this library does, at least for me who is not familiar with kldxref internals. I don't have any objection to the change itself, it seems fine and will be useful for debuggers and related tools. libdtrace might be able to take advantage of it as well, replacing some existing code.
Comment Actions Update commit message. If it is not reflected on Phabricator I will do it one more time. Comment Actions This seems ok to me. Please make sure you test MacOS and Linux builds as well, e.g., with a PR on github. It would be nice to see the patches for intended consumers (libkvm?) before this lands, though.
Comment Actions Bootstrap it everytime, and remove the __FreeBSD_version bump as well given this library is private. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||