Paths

Table of Contentst

Differential D46295

add virtio file system device support
Needs ReviewPublic
Actions

Authored by emil_etsalapatis.com on Aug 14 2024, 3:53 PM.

Tags

None

Referenced Files

	F164061436: D46295.id156285.diff
	Tue, Jul 28, 9:32 AM

	F164025542: D46295.diff
	Tue, Jul 28, 1:11 AM

	Unknown Object (File)
	Sun, Jul 26, 4:00 PM

	Unknown Object (File)
	Sun, Jul 26, 6:05 AM

	Unknown Object (File)
	Sun, Jul 26, 1:08 AM

	Unknown Object (File)
	Sat, Jul 25, 9:59 PM

	Unknown Object (File)
	Sat, Jul 25, 5:55 PM

	Unknown Object (File)
	Sat, Jul 25, 4:10 PM

Subscribers

crest_freebsd_rlwinm.de

stefan.ractliffe_metrakol.ch

Details

Reviewers

asomers
editor_callfortesting.org

Summary

Supporting the virtiofs requires a device driver for the virtio fs device. Add the virtio file system driver before introducing the file system itself.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 59021
Build 55908: arc lint + arc unit

Event Timeline

emil_etsalapatis.com created this revision.Aug 14 2024, 3:53 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 14 2024, 3:53 PM

emil_etsalapatis.com requested review of this revision.Aug 14 2024, 3:53 PM

Harbormaster completed remote builds in B59021: Diff 142082.Aug 14 2024, 3:53 PM

lwhsu added a subscriber: lwhsu.Aug 14 2024, 4:29 PM

lwhsu added inline comments.

sys/dev/virtio/fs/virtio_fs.h
4	We need a copyright holder here, and may drop "all rights reserved."

crest_freebsd_rlwinm.de added a subscriber: crest_freebsd_rlwinm.de.Aug 15 2024, 6:39 PM

asomers requested changes to this revision.Aug 21 2024, 7:30 PM

asomers added inline comments.

sys/dev/virtio/fs/virtio_fs.c
58	This line is redundant with the one in virtio_fs.h
296
550–551
sys/dev/virtio/fs/virtio_fs_internal.h
10	If these messages are just for debugging purposes, shouldn't there be a way to turn them off?

This revision now requires changes to proceed.Aug 21 2024, 7:30 PM

address reviewer feedback

Harbormaster completed remote builds in B61687: Diff 149165.Jan 13 2025, 1:16 AM

sys/dev/virtio/fs: drain virtqueues one at a time

Harbormaster completed remote builds in B64541: Diff 156285.May 30 2025, 2:26 AM

lwhsu added inline comments.May 30 2025, 2:51 AM

sys/dev/virtio/fs/virtio_fs.h
3	`BSD-2-Clause` is fine, no need `-FreeBSD` suffix

sys/dev/virtio/fs: use regular BSD-2-Clause license

Harbormaster completed remote builds in B64544: Diff 156288.May 30 2025, 4:34 AM

bug fixes and style updates

Harbormaster completed remote builds in B70328: Diff 170959.Feb 1 2026, 11:56 PM

adjust SPDX License Identifier

Harbormaster completed remote builds in B70331: Diff 170963.Feb 2 2026, 12:04 AM

emil_etsalapatis.com mentioned this in D55047: fuse: Do not unconditionally overwrite local vnode size with remote.Feb 2 2026, 3:50 AM

emil_etsalapatis.com mentioned this in D46296: add virtiofs kernel module.Jun 22 2026, 6:55 AM

rebased on HEAD

Harbormaster completed remote builds in B74946: Diff 182276.Mon, Jul 20, 8:26 AM

stefan.ractliffe_metrakol.ch added a subscriber: stefan.ractliffe_metrakol.ch.Mon, Jul 20, 11:37 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

1 line

conf/

1 line

dev/

virtio/

fs/

44 lines

606 lines

virtio_fs_internal.h

60 lines

modules/

virtio/

2 lines

	fs/

11 lines

Diff 142082

sys/amd64/conf/GENERIC

Loading...

sys/conf/files

Loading...

sys/dev/virtio/fs/virtio_fs.h

Loading...

sys/dev/virtio/fs/virtio_fs.c

Loading...

sys/dev/virtio/fs/virtio_fs_internal.h

Loading...

sys/modules/virtio/Makefile

Loading...

sys/modules/virtio/fs/Makefile

Loading...