Page MenuHomeFreeBSD
Differential D44380

syscalls.master: don't use struct siginfo
ClosedPublic
Actions

Authored by brooks on Mar 15 2024, 10:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 29, 11:25 PM
Unknown Object (File)
Tue, Apr 28, 5:06 PM
Unknown Object (File)
Mon, Apr 27, 2:46 PM
Unknown Object (File)
Mon, Apr 27, 12:21 PM
Unknown Object (File)
Mon, Apr 27, 10:59 AM
Unknown Object (File)
Sat, Apr 25, 5:50 AM
Unknown Object (File)
Mon, Apr 20, 7:56 PM
Unknown Object (File)
Tue, Apr 7, 11:15 PM
View All Files
Subscribers
emaste
imp
jhibbits
olce

Details

Reviewers
kib
andrew
manu
Commits
rGcab73e530564: syscalls.master: struct siginfo -> struct __siginfo
rGd060b420e0f6: freebsd32: struct siginfo32 -> struct __siginfo32
Summary

It doesn't exist. Instead, use struct __siginfo which does.

Rename struct siginfo32 to struct __siginfo32 to keep the ABI
transformations in makesyscalls.lua working.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Mar 15 2024, 10:45 PM
Herald added a reviewer: andrew. · View Herald TranscriptMar 15 2024, 10:45 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: olce, jhibbits, emaste, imp. · View Herald Transcript
brooks requested review of this revision.Mar 15 2024, 10:45 PM
Harbormaster completed remote builds in B56634: Diff 135804.Mar 15 2024, 10:45 PM
brooks added a parent revision: D44379: syscalls.master: align with sigfastblock declaration.Mar 15 2024, 10:45 PM
brooks added a child revision: D44387: libsys: add a libsys.h.Mar 15 2024, 10:48 PM
kib accepted this revision.Mar 16 2024, 1:35 AM

I would prefer this one split into two: siginfo32 first, the siginfo second, even if the inter-commit base cannot be built.

This revision is now accepted and ready to land.Mar 16 2024, 1:35 AM
brooks added a comment.Mar 18 2024, 9:44 PM
In D44380#1012169, @kib wrote:

I would prefer this one split into two: siginfo32 first, the siginfo second, even if the inter-commit base cannot be built.

I've made this split locally.

Closed by commit rGd060b420e0f6: freebsd32: struct siginfo32 -> struct __siginfo32 (authored by brooks). · Explain WhyMar 19 2024, 11:16 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGd060b420e0f6: freebsd32: struct siginfo32 -> struct __siginfo32.
brooks added a commit: rGcab73e530564: syscalls.master: struct siginfo -> struct __siginfo.

Revision Contents
Changeset List

PathSize
sys/
amd64/
ia32/
4 lines
arm64/
arm64/
5 lines
include/
2 lines
compat/
freebsd32/
14 lines
2 lines
ia32/
4 lines
2 lines
powerpc/
powerpc/
6 lines
sys/
2 lines
2 lines

Diff 135970

View Options

sys/amd64/ia32/ia32_signal.c

Loading...
View Options

sys/arm64/arm64/freebsd32_machdep.c

Loading...
View Options

sys/arm64/include/frame.h

Loading...
View Options

sys/compat/freebsd32/freebsd32_misc.c

Loading...
View Options

sys/compat/freebsd32/freebsd32_signal.h

Loading...
View Options

sys/compat/ia32/ia32_signal.h

Loading...
View Options

sys/compat/ia32/ia32_sysvec.c

Loading...
View Options

sys/powerpc/powerpc/exec_machdep.c

Loading...
View Options

sys/sys/ptrace.h

Loading...
View Options

sys/sys/signal.h

Loading...