libsys: add a libsys.h
ClosedPublic
Actions

Authored by brooks on Mar 15 2024, 10:47 PM.

Details

Reviewers

Commits

Summary

This declares an API for libsys which currently consists of
sys_<foo>() declarations for system call stubs and function pointer
typedefs of the form sys_<foo>_t. The vast majority of the
implementation resides in a generated _libsys.h which ensures that all
system call stub declarations match syscalls.master.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Mar 15 2024, 10:47 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMar 15 2024, 10:47 PM

brooks requested review of this revision.Mar 15 2024, 10:47 PM

Harbormaster completed remote builds in B56640: Diff 135810.Mar 15 2024, 10:47 PM

brooks added parent revisions: D44386: makesyscalls: generate core libsys header, D44385: Define idtype_t in sys/_idtype.h, D44381: Make __sys_fcntl take an intptr_t, D44380: syscalls.master: don't use struct siginfo.Mar 15 2024, 10:48 PM

brooks added a child revision: D44388: lib{c,rt}: use libsys.h for __sys_* declerations.Mar 15 2024, 10:48 PM

declEration typo in the description

This revision is now accepted and ready to land.Mar 16 2024, 2:35 AM

brooks mentioned this in D44386: makesyscalls: generate core libsys header.Mar 18 2024, 7:11 PM

kib added inline comments.Mar 18 2024, 7:49 PM

lib/libsys/_libsys.h
68	Does __BEGIN_DECLS provide enough force to make compiler attach the right call ABI to the typedef'ed function types?

brooks added inline comments.Mar 18 2024, 8:44 PM

lib/libsys/_libsys.h
68	My thought was that it prevents them from being name mangled in C++, but even there I'm not sure it matters on any architecture we care about? Maybe there would otherwise be an edge case where type promotion differences were an issue. It might be we don't need this around the typedefs.