Paths

Table of Contentst

Differential D44389

libc: INTERPOS_SYS macro for interposed syscalls
ClosedPublic
Actions

Authored by brooks on Mar 15 2024, 10:49 PM.

Tags

None

Referenced Files

	F161192484: D44389.diff
	Wed, Jul 1, 11:29 AM

	Unknown Object (File)
	Tue, Jun 30, 12:52 PM

	Unknown Object (File)
	Mon, Jun 29, 5:26 PM

	Unknown Object (File)
	Thu, Jun 25, 7:11 AM

	Unknown Object (File)
	Wed, Jun 24, 2:34 PM

	Unknown Object (File)
	Wed, Jun 24, 6:03 AM

	Unknown Object (File)
	Tue, Jun 23, 6:44 PM

	Unknown Object (File)
	Sun, Jun 21, 11:38 PM

Subscribers

Details

Reviewers

Commits

rG7dd9070e4425: libc: INTERPOS_SYS macro for interposed syscalls

Summary

This macro makes uses the __sys_<foo>_t typedefs from libsys.h to
greatly simplify calling functions in the interposing table.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Mar 15 2024, 10:49 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 15 2024, 10:49 PM

brooks requested review of this revision.Mar 15 2024, 10:49 PM

Harbormaster completed remote builds in B56642: Diff 135812.Mar 15 2024, 10:49 PM

brooks added a parent revision: D44388: lib{c,rt}: use libsys.h for __sys_* declerations.Mar 15 2024, 10:49 PM

kib added inline comments.Mar 16 2024, 2:41 AM

lib/libc/include/libc_private.h
256
257	Did you considered adding vararg args to the INTERPOS_SYS() so that it provides complete syntax for the call, instead of requiring (args) after as independent tokens?

Make INTERPOS_SYS varargs

Harbormaster completed remote builds in B56684: Diff 135915.Mar 18 2024, 7:40 PM

space in (type *)

Harbormaster completed remote builds in B56685: Diff 135916.Mar 18 2024, 7:41 PM

Technically the var args change requires C23/C++20 for __VA_OPT__, but all the compiler we care about support it regardless of compilation mode (gcc 8+ and clang 12+).

kib accepted this revision.Mar 18 2024, 7:54 PM

This revision is now accepted and ready to land.Mar 18 2024, 7:54 PM

Closed by commit rG7dd9070e4425: libc: INTERPOS_SYS macro for interposed syscalls (authored by brooks). · Explain WhyApr 16 2024, 4:50 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG7dd9070e4425: libc: INTERPOS_SYS macro for interposed syscalls.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

4 lines

4 lines

include/

6 lines

sys/

3 lines

4 lines

5 lines

clock_nanosleep.c

5 lines

2 lines

3 lines

5 lines

3 lines

3 lines

2 lines

2 lines

6 lines

3 lines

3 lines

3 lines

4 lines

4 lines

4 lines

3 lines

4 lines

4 lines

3 lines

3 lines

5 lines

5 lines

3 lines

3 lines

5 lines

3 lines

5 lines

3 lines

3 lines

3 lines

3 lines

4 lines

3 lines

3 lines

3 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

3 lines

3 lines

Diff 137114

lib/libc/gen/sleep.c

Loading...

lib/libc/gen/usleep.c

Loading...

lib/libc/include/libc_private.h

Loading...

lib/libc/sys/accept.c

Loading...

lib/libc/sys/accept4.c

Loading...

lib/libc/sys/aio_suspend.c

Loading...

lib/libc/sys/clock_nanosleep.c

Loading...

lib/libc/sys/close.c

Loading...

lib/libc/sys/connect.c

Loading...

lib/libc/sys/creat.c

Loading...

lib/libc/sys/fcntl.c

Loading...

lib/libc/sys/fdatasync.c

Loading...

lib/libc/sys/fork.c

Loading...

lib/libc/sys/fsync.c

Loading...

lib/libc/sys/kevent.c

Loading...

lib/libc/sys/lockf.c

Loading...

lib/libc/sys/msync.c

Loading...

lib/libc/sys/nanosleep.c

Loading...

lib/libc/sys/open.c

Loading...

lib/libc/sys/openat.c

Loading...

lib/libc/sys/pdfork.c

Loading...

lib/libc/sys/poll.c

Loading...

lib/libc/sys/ppoll.c

Loading...

lib/libc/sys/pselect.c

Loading...

lib/libc/sys/read.c

Loading...

lib/libc/sys/readv.c

Loading...

lib/libc/sys/recv.c

Loading...

lib/libc/sys/recvfrom.c

Loading...

lib/libc/sys/recvmsg.c

Loading...

lib/libc/sys/select.c

Loading...

lib/libc/sys/send.c

Loading...

lib/libc/sys/sendmsg.c

Loading...

lib/libc/sys/sendto.c

Loading...

lib/libc/sys/setcontext.c

Loading...

lib/libc/sys/sigaction.c

Loading...

lib/libc/sys/sigprocmask.c

Loading...

lib/libc/sys/sigsuspend.c

Loading...

lib/libc/sys/sigtimedwait.c

Loading...

lib/libc/sys/sigwait.c

Loading...

lib/libc/sys/sigwaitinfo.c

Loading...

lib/libc/sys/swapcontext.c

Loading...

lib/libc/sys/wait.c

Loading...

lib/libc/sys/wait3.c

Loading...

lib/libc/sys/wait4.c

Loading...

lib/libc/sys/wait6.c

Loading...

lib/libc/sys/waitid.c

Loading...

lib/libc/sys/waitpid.c

Loading...

lib/libc/sys/write.c

Loading...

lib/libc/sys/writev.c

Loading...