Page MenuHomeFreeBSD
Differential D44389

libc: INTERPOS_SYS macro for interposed syscalls
ClosedPublic
Actions

Authored by brooks on Mar 15 2024, 10:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 9:12 PM
Unknown Object (File)
Fri, May 10, 1:30 AM
Unknown Object (File)
Mon, May 6, 11:19 PM
Unknown Object (File)
Mon, May 6, 10:46 AM
Unknown Object (File)
Sat, May 4, 1:23 PM
Unknown Object (File)
Fri, Apr 26, 6:12 AM
Unknown Object (File)
Fri, Apr 26, 4:17 AM
Unknown Object (File)
Thu, Apr 25, 7:25 PM
View All 16 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rG7dd9070e4425: libc: INTERPOS_SYS macro for interposed syscalls
Summary

This macro makes uses the __sys_<foo>_t typedefs from libsys.h to
greatly simplify calling functions in the interposing table.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56685
Build 53573: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 15 2024, 10:49 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 15 2024, 10:49 PM
brooks requested review of this revision.Mar 15 2024, 10:49 PM
Harbormaster completed remote builds in B56642: Diff 135812.Mar 15 2024, 10:49 PM
brooks added a parent revision: D44388: lib{c,rt}: use libsys.h for __sys_* declerations.Mar 15 2024, 10:49 PM
kib added inline comments.Mar 16 2024, 2:41 AM
lib/libc/include/libc_private.h
256
257

Did you considered adding vararg args to the INTERPOS_SYS() so that it provides complete syntax for the call, instead of requiring (args) after as independent tokens?

brooks updated this revision to Diff 135915.Mar 18 2024, 7:40 PM

Make INTERPOS_SYS varargs

Harbormaster completed remote builds in B56684: Diff 135915.Mar 18 2024, 7:40 PM
brooks updated this revision to Diff 135916.Mar 18 2024, 7:41 PM

space in (type *)

Harbormaster completed remote builds in B56685: Diff 135916.Mar 18 2024, 7:41 PM
brooks marked 2 inline comments as done.EditedMar 18 2024, 7:42 PM

Technically the var args change requires C23/C++20 for __VA_OPT__, but all the compiler we care about support it regardless of compilation mode (gcc 8+ and clang 12+).

kib accepted this revision.Mar 18 2024, 7:54 PM
This revision is now accepted and ready to land.Mar 18 2024, 7:54 PM
Closed by commit rG7dd9070e4425: libc: INTERPOS_SYS macro for interposed syscalls (authored by brooks). · Explain WhyTue, Apr 16, 4:50 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG7dd9070e4425: libc: INTERPOS_SYS macro for interposed syscalls.

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
4 lines
4 lines
include/
6 lines
sys/
3 lines
4 lines
5 lines
5 lines
2 lines
3 lines
5 lines
3 lines
3 lines
2 lines
2 lines
6 lines
3 lines
3 lines
3 lines
4 lines
4 lines
4 lines
3 lines
4 lines
4 lines
3 lines
3 lines
5 lines
5 lines
3 lines
3 lines
5 lines
3 lines
5 lines
3 lines
3 lines
3 lines
3 lines
4 lines
3 lines
3 lines
3 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
3 lines
3 lines

Diff 135916

View Options

lib/libc/gen/sleep.c

Loading...
View Options

lib/libc/gen/usleep.c

Loading...
View Options

lib/libc/include/libc_private.h

Loading...
View Options

lib/libc/sys/accept.c

Loading...
View Options

lib/libc/sys/accept4.c

Loading...
View Options

lib/libc/sys/aio_suspend.c

Loading...
View Options

lib/libc/sys/clock_nanosleep.c

Loading...
View Options

lib/libc/sys/close.c

Loading...
View Options

lib/libc/sys/connect.c

Loading...
View Options

lib/libc/sys/creat.c

Loading...
View Options

lib/libc/sys/fcntl.c

Loading...
View Options

lib/libc/sys/fdatasync.c

Loading...
View Options

lib/libc/sys/fork.c

Loading...
View Options

lib/libc/sys/fsync.c

Loading...
View Options

lib/libc/sys/kevent.c

Loading...
View Options

lib/libc/sys/lockf.c

Loading...
View Options

lib/libc/sys/msync.c

Loading...
View Options

lib/libc/sys/nanosleep.c

Loading...
View Options

lib/libc/sys/open.c

Loading...
View Options

lib/libc/sys/openat.c

Loading...
View Options

lib/libc/sys/pdfork.c

Loading...
View Options

lib/libc/sys/poll.c

Loading...
View Options

lib/libc/sys/ppoll.c

Loading...
View Options

lib/libc/sys/pselect.c

Loading...
View Options

lib/libc/sys/read.c

Loading...
View Options

lib/libc/sys/readv.c

Loading...
View Options

lib/libc/sys/recv.c

Loading...
View Options

lib/libc/sys/recvfrom.c

Loading...
View Options

lib/libc/sys/recvmsg.c

Loading...
View Options

lib/libc/sys/select.c

Loading...
View Options

lib/libc/sys/send.c

Loading...
View Options

lib/libc/sys/sendmsg.c

Loading...
View Options

lib/libc/sys/sendto.c

Loading...
View Options

lib/libc/sys/setcontext.c

Loading...
View Options

lib/libc/sys/sigaction.c

Loading...
View Options

lib/libc/sys/sigprocmask.c

Loading...
View Options

lib/libc/sys/sigsuspend.c

Loading...
View Options

lib/libc/sys/sigtimedwait.c

Loading...
View Options

lib/libc/sys/sigwait.c

Loading...
View Options

lib/libc/sys/sigwaitinfo.c

Loading...
View Options

lib/libc/sys/swapcontext.c

Loading...
View Options

lib/libc/sys/wait.c

Loading...
View Options

lib/libc/sys/wait3.c

Loading...
View Options

lib/libc/sys/wait4.c

Loading...
View Options

lib/libc/sys/wait6.c

Loading...
View Options

lib/libc/sys/waitid.c

Loading...
View Options

lib/libc/sys/waitpid.c

Loading...
View Options

lib/libc/sys/write.c

Loading...
View Options

lib/libc/sys/writev.c

Loading...