Differential D44385

Define idtype_t in sys/_idtype.h
Needs ReviewPublic
Actions

Authored by brooks on Mar 15 2024, 10:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 10, 12:30 PM

	Unknown Object (File)
	Mon, May 6, 7:09 PM

	Unknown Object (File)
	Mon, May 6, 5:00 PM

	Unknown Object (File)
	Sat, May 4, 1:23 PM

	Unknown Object (File)
	Fri, Apr 26, 12:14 PM

	Unknown Object (File)
	Fri, Apr 26, 4:16 AM

	Unknown Object (File)
	Fri, Apr 26, 3:13 AM

	Unknown Object (File)
	Mon, Apr 22, 1:43 PM

View All 11 Files

Subscribers

Details

Reviewers

kib
emaste

Summary

The wait6(2) definition needs this type so make it available without all
of wait.h.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56704
Build 53592: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 15 2024, 10:47 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 15 2024, 10:47 PM

brooks requested review of this revision.Mar 15 2024, 10:47 PM

brooks added a parent revision: D44383: Define stack_t in sys/_sigaltstack.h.

Harbormaster completed remote builds in B56638: Diff 135808.Mar 15 2024, 10:47 PM

brooks added a child revision: D44387: libsys: add a libsys.h.Mar 15 2024, 10:48 PM

kib accepted this revision.Mar 16 2024, 2:28 AM

kib added inline comments.

sys/sys/_idtype.h
30	I do not believe that this copyright is relevant for the file content. You might want to contact the author about changing that to 2-bsd.

This revision is now accepted and ready to land.Mar 16 2024, 2:28 AM

kib added a reviewer: emaste.Mar 16 2024, 2:29 AM

brooks removed a parent revision: D44383: Define stack_t in sys/_sigaltstack.h.Mar 19 2024, 11:23 PM

Rebase and wait.h -> _idtype.h change

This revision now requires review to proceed.Mar 19 2024, 11:31 PM

Harbormaster completed remote builds in B56704: Diff 135981.Mar 19 2024, 11:32 PM

brooks removed a child revision: D44387: libsys: add a libsys.h.Mar 19 2024, 11:35 PM

brooks added a parent revision: D44387: libsys: add a libsys.h.

While we wait to see if the wait6 author answers my license query, I've switched back to just including wait.h in my main libsys.h patch and rebased on top of that change. wait.h isn't all that bad in terms of header pollution.

Revision Contents
Changeset List

Path

Size

lib/

libsys/

sys/

sys/

77 lines

41 lines

tools/

makesyscalls.lua

2 lines

Diff 135981

lib/libsys/_libsys.h

Loading...

sys/sys/_idtype.h

Loading...

sys/sys/wait.h

Loading...

sys/tools/makesyscalls.lua

Loading...