Page MenuHomeFreeBSD
Differential D38664

Remove support for EOL FreeBSD 12.3 Purposefully not touching misc/freebsd-release-manifests as re@ will take care of that themselves.
ClosedPublic
Actions

Authored by rene on Feb 18 2023, 12:08 PM.
Tags
None
Referenced Files
F138072065: D38664.id118660.diff
Fri, Nov 28, 4:08 PM
Unknown Object (File)
Tue, Nov 25, 4:47 AM
Unknown Object (File)
Mon, Nov 24, 6:42 PM
Unknown Object (File)
Wed, Nov 19, 7:27 AM
Unknown Object (File)
Sat, Nov 15, 3:28 PM
Unknown Object (File)
Sun, Nov 9, 5:33 AM
Unknown Object (File)
Sat, Nov 8, 7:40 AM
Unknown Object (File)
Thu, Nov 6, 11:01 PM
View All Files
Subscribers
adridg
antoine
mat
pkubaj

Details

Reviewers
jbeich
salvadore
loader
tagattie
yuri
nobutaka
jwb
pkubaj
Group Reviewers
portmgr
rust
chromium
kde
Commits
R11:56932296b7bc: */*: Sunset 12.3-RELEASE from ports tree
Summary

Mk/bsd.port.mk: mark FreeBSD 12.3 as unsupported.

databases/mongodb60: remove IGNORE for EOL FreeBSD 12.3

devel/freebsd-sysroot: wonder if this should go to 12.4-RELEASE

devel/malloy: this should build fine on 12.4-RELEASE

emulators/ppsspp: remove workaround for EOL FreeBSD 12.3

emulators/yuzu: remove workaround for EOL 12.3-RELEASE

games/punchy: remove workaround for EOL FreeBSD 12.3

lang/gcc11*: bump a __FreeBSD_version in libphobos to 1204000

misc/mbuffer: remove workaround for EOL FreeBSD 12.3 for aarch64

sysutils/libdisplay-info: remove workaround for EOL FreeBSD 12.3

www/*chromium: remove IGNORE for EOL FreeBSD 12.3

www/iridium: remove IGNORE for EOL FreeBSD 12.3

x11-wm/kwinft: remove workaround for EOL FreeBSD 12.3

x11-wm/labwc: remove workaround for EOL FreeBSD 12.3

x11/hyprpaper: remove workaround for expired FreeBSD 12.3

devel/electron22: remove IGNORE for EOL FreeBSD 12.3

lang/rust: untangle OSVERSION logic a bit

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 49930
Build 46822: arc lint + arc unit

Event Timeline

rene created this revision.Feb 18 2023, 12:08 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptFeb 18 2023, 12:08 PM
Herald added a subscriber: mat. · View Herald Transcript
rene requested review of this revision.Feb 18 2023, 12:08 PM
Harbormaster completed remote builds in B49876: Diff 117537.Feb 18 2023, 12:08 PM
salvadore accepted this revision.Feb 18 2023, 5:47 PM

Tested successfully and approved as far as lang/gcc11 and lang/gcc11-devel are concerned.

antoine added a subscriber: antoine.Feb 18 2023, 7:40 PM

this seems a bit early, we have to support 12.3 6 more weeks

jbeich accepted this revision.Feb 18 2023, 8:41 PM
jbeich added inline comments.
x11/hyprpaper/distinfo
-2–1

Drop TIMESTAMP part: during an OS upgrade builds are not reproducible.

jbeich added a comment.Feb 18 2023, 11:37 PM

More ports with 12.3-specific cruft:

  • biology/wfa2-lib/files/patch-system_profiler__timer.h
  • devel/concurrencpp/Makefile (BROKEN_FreeBSD_12)
  • devel/qcoro/Makefile (BROKEN_FreeBSD_12)
  • devel/root/Makefile (post-patch, not sure about PLIST_FILES)
  • editors/imhex/Makefile (OSMAJOR + IGNORE + pre.mk/post.mk)
  • emulators/rpcs3/Makefile (bundled-libcxx)
  • graphics/cxxplot/Makefile (BROKEN_FreeBSD_12)
loader accepted this revision.Feb 19 2023, 3:01 AM

misc/mbuffer: ok

tagattie accepted this revision.Feb 19 2023, 10:57 AM

devel/electron22: looks good. thank you working on this.

jbeich added inline comments.Feb 19 2023, 11:48 AM
databases/mongodb60/Makefile
94

Breaks build outside of poudriere. ${ARCH} requires at least bsd.port.options.mk.

$ make describe
make: "/usr/ports/databases/mongodb60/Makefile" line 102: Malformed conditional (${ARCH} == amd64)
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/ports/databases/mongodb60
devel/electron22/Makefile
227

Breaks build outside of poudriere. ${ARCH} requires at least bsd.port.options.mk.

$ make describe
make: "/usr/ports/devel/electron22/Makefile" line 228: Malformed conditional (${PORT_OPTIONS:MHEIMDAL_BASE} && !exists(/usr/lib/libkrb5.so))
make: "/usr/ports/devel/electron22/Makefile" line 232: Malformed conditional (${COMPILER_VERSION} != 130)
make: "/usr/ports/devel/electron22/Makefile" line 246: Malformed conditional (${ARCH} == "amd64")
make: "/usr/ports/devel/electron22/Makefile" line 252: Malformed conditional (${ARCH} == "i386")
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/ports/devel/electron22
www/chromium/Makefile
212

Breaks build: ${COMPILER_VERSION} is defined by USES=compiler, so requires pre/post.

$ make -V BUILD_DEPENDS
make: "/usr/ports/www/chromium/Makefile" line 226: Malformed conditional (${COMPILER_VERSION} != 130)
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/ports/www/chromium
www/iridium/Makefile
199

Breaks build: ${COMPILER_VERSION} is defined by USES=compiler, so requires pre/post.

$ make -V BUILD_DEPENDS
make: "/usr/ports/www/iridium/Makefile" line 204: Malformed conditional (${COMPILER_VERSION} != 130)
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/ports/www/iridium
www/ungoogled-chromium/Makefile
227

Breaks build: ${COMPILER_VERSION} is defined by USES=compiler, so requires pre/post.

$ make -V BUILD_DEPENDS
make: "/usr/ports/www/ungoogled-chromium/Makefile" line 232: Malformed conditional (${COMPILER_VERSION} != 130)
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/ports/www/ungoogled-chromium
rene updated this revision to Diff 117588.EditedFeb 19 2023, 11:51 AM

Rebase after eb35c77bfe9c

  1. Updating D38664: Remove support for EOL FreeBSD 12.3
Harbormaster completed remote builds in B49887: Diff 117588.Feb 19 2023, 11:51 AM
rene updated this revision to Diff 117589.EditedFeb 19 2023, 12:20 PM

Catch up with latest main

  • devel/concurrencpp: remove workaround for EOL FreeBSD 12.3
  • devel/qcoro: remove BROKEN for EOL FreeBSD 12.3
  • devel/root: remove workaround for EOL FreeBSD 12.3
  • editors/imhex: remove IGNORE for EOL FreeBSD 12.3 (and pre-2022 14-CURRENT)
  • graphics/cxxplot: remove support for EOL FreeBSD 12.3
  1. Updating D38664: Remove support for EOL FreeBSD 12.3
Harbormaster completed remote builds in B49888: Diff 117589.Feb 19 2023, 12:20 PM
rene added reviewers: yuri, nobutaka, kde.Feb 19 2023, 12:23 PM
rene marked 6 inline comments as done.Feb 19 2023, 12:34 PM
rene updated this revision to Diff 117590.Feb 19 2023, 12:34 PM
  • *: fix make describe
  • x11/hyprpaper: revert TIMESTAMP update in distinfo to keep build reproducible
Harbormaster completed remote builds in B49889: Diff 117590.Feb 19 2023, 12:34 PM
rene added a comment.Feb 19 2023, 12:38 PM
In D38664#879945, @antoine wrote:

this seems a bit early, we have to support 12.3 6 more weeks

I know, that is what the title says. The idea is to have things ironed out beforehand so it does not affect 2023Q2.

jbeich added a comment.Feb 19 2023, 1:31 PM

Did you forget biology/wfa2-lib and emulators/rpcs3? I test rpcs3 build on 12.4 regularly where bundled-libcxx is not used.

devel/electron22/Makefile
227

Still broken: ${COMPILER_VERSION} is defined by USES=compiler, so requires pre/post.

$ make describe                                                                                           poudriere γ devel/electron22
make: "/usr/ports/devel/electron22/Makefile" line 233: Malformed conditional (${COMPILER_VERSION} != 130)
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/ports/devel/electron22
rene marked an inline comment as done.Feb 19 2023, 2:10 PM
In D38664#880158, @jbeich wrote:

Did you forget biology/wfa2-lib and emulators/rpcs3? I test rpcs3 build on 12.4 regularly where bundled-libcxx is not used.

Hmm, I must have missed those two ports. I've added them to this review.

rene updated this revision to Diff 117593.Feb 19 2023, 2:11 PM
  • biology/wfa2-lib: remove obsolete patch
  • emulators/rpcs3: remove workaround for EOL FreeBSD 12.3
  • devel/electron22: second attempt to fix make describe
Harbormaster completed remote builds in B49890: Diff 117593.Feb 19 2023, 2:11 PM
rene added a reviewer: jwb.Feb 19 2023, 2:12 PM
yuri accepted this revision.Feb 19 2023, 4:34 PM
rene updated this revision to Diff 117706.EditedFeb 21 2023, 9:01 PM

Rebase.

  1. Updating D38664: Remove support for EOL FreeBSD 12.3
Harbormaster completed remote builds in B49930: Diff 117706.Feb 21 2023, 9:01 PM
pkubaj added a subscriber: pkubaj.Feb 22 2023, 6:30 PM
pkubaj added inline comments.
devel/freebsd-sysroot/Makefile
48

Please see https://reviews.freebsd.org/D37698. It will need to be rebased since powerpcspe flavor was added recently, but that's a minor change since powerpcspe flavor uses 13.1-RELEASE anyway.

pkubaj accepted this revision.Feb 22 2023, 6:31 PM
nobutaka accepted this revision.Feb 23 2023, 5:21 AM
rene updated this revision to Diff 117907.Feb 25 2023, 1:18 PM

Rebase

Harbormaster completed remote builds in B50000: Diff 117907.Feb 25 2023, 1:18 PM
jbeich added a comment.Mar 1 2023, 9:42 PM

dae4d6bdd2a5 added one more place to clean up after 12.3 EOL.

rene updated this revision to Diff 118646.Mar 10 2023, 9:18 PM

Rebase

Harbormaster completed remote builds in B50286: Diff 118646.Mar 10 2023, 9:18 PM
rene updated this revision to Diff 118660.Mar 11 2023, 3:13 PM
  • games/aquaria: remove support for EOL FreeBSD 12.3
  1. Updating D38664: Remove support for EOL FreeBSD 12.3
Harbormaster completed remote builds in B50291: Diff 118660.Mar 11 2023, 3:13 PM
adridg added a subscriber: adridg.Mar 12 2023, 4:41 PM

For kde@, devel/qcoro looks good. (It builds on 12.4)

rene updated this revision to Diff 119043.Mar 18 2023, 12:28 PM

Rebase

Harbormaster completed remote builds in B50452: Diff 119043.Mar 18 2023, 12:28 PM
rene updated this revision to Diff 119420.Mar 24 2023, 7:22 PM

Revert "Uses/cabal.mk: Extend the text-2 workaround to 12.3-RELEASE."

Harbormaster completed remote builds in B50574: Diff 119420.Mar 24 2023, 7:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 31 2023, 12:01 AM
Closed by commit R11:56932296b7bc: */*: Sunset 12.3-RELEASE from ports tree (authored by bofh). · Explain Why
This revision was automatically updated to reflect the committed changes.
bofh added a commit: R11:56932296b7bc: */*: Sunset 12.3-RELEASE from ports tree.

Revision Contents
Changeset List

PathSize
Mk/
6 lines
biology/
wfa2-lib/
files/
databases/
mongodb60/
4 lines
devel/
concurrencpp/
5 lines
electron22/
6 lines
freebsd-sysroot/
2 lines
malloy/
3 lines
qcoro/
5 lines
root/
13 lines
editors/
imhex/
12 lines
emulators/
ppsspp/
6 lines
rpcs3/
20 lines
yuzu/
4 lines
games/
punchy/
6 lines
graphics/
cxxplot/
5 lines
lang/
gcc11-devel/
files/
2 lines
gcc11/
files/
2 lines
rust/
4 lines
misc/
mbuffer/
8 lines
files/
sysutils/
libdisplay-info/
8 lines
www/
chromium/
6 lines
iridium/
6 lines
ungoogled-chromium/
6 lines
x11-wm/
kwinft/
24 lines
2 lines
labwc/
5 lines
x11/
hyprpaper/
23 lines
2 lines

Diff 117706

View Options

Mk/bsd.port.mk

Loading...
View Options

biology/wfa2-lib/files/patch-system_profiler__timer.h

Loading...
View Options

databases/mongodb60/Makefile

Loading...
View Options

devel/concurrencpp/Makefile

Loading...
View Options

devel/electron22/Makefile

Loading...
View Options

devel/freebsd-sysroot/Makefile

Loading...
View Options

devel/malloy/Makefile

Loading...
View Options

devel/qcoro/Makefile

Loading...
View Options

devel/root/Makefile

Loading...
View Options

editors/imhex/Makefile

Loading...
View Options

emulators/ppsspp/Makefile

Loading...
View Options

emulators/rpcs3/Makefile

Loading...
View Options

emulators/yuzu/Makefile

Loading...
View Options

games/punchy/Makefile

Loading...
View Options

graphics/cxxplot/Makefile

Loading...
View Options

lang/gcc11-devel/files/patch-libphobos_libdruntime_core_sys_freebsd_config.d

Loading...
View Options

lang/gcc11/files/patch-libphobos_libdruntime_core_sys_freebsd_config.d

Loading...
View Options

lang/rust/Makefile

Loading...
View Options

misc/mbuffer/Makefile

Loading...
View Options

misc/mbuffer/files/extra-patch-12.3

Loading...
View Options

sysutils/libdisplay-info/Makefile

Loading...
View Options

www/chromium/Makefile

Loading...
View Options

www/iridium/Makefile

Loading...
View Options

www/ungoogled-chromium/Makefile

Loading...
View Options

x11-wm/kwinft/Makefile

Loading...
View Options

x11-wm/kwinft/distinfo

Loading...
View Options

x11-wm/labwc/Makefile

Loading...
View Options

x11/hyprpaper/Makefile

Loading...
View Options

x11/hyprpaper/distinfo

Loading...