Differential D60704

acpi_lid: add an in-kernel lid state eventhandler
ClosedPublic
Actions

Authored by seuros on Tue, Oct 13, 3:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 14, 8:31 AM

	Unknown Object (File)
	Wed, Oct 14, 8:27 AM

	Unknown Object (File)
	Wed, Oct 14, 3:18 AM

	Unknown Object (File)
	Wed, Oct 14, 1:10 AM

	Unknown Object (File)
	Wed, Oct 14, 12:32 AM

	Unknown Object (File)
	Tue, Oct 13, 10:00 PM

	Unknown Object (File)
	Tue, Oct 13, 6:03 PM

	Unknown Object (File)
	Tue, Oct 13, 4:49 PM

View All 10 Files

Subscribers

Details

Reviewers

adrian
olce

Commits

rG030e556ff8a9: acpi_lid: add an in-kernel lid state eventhandler

Summary

Lid state changes are only published to userland, via devd and evdev.
Drivers that need to react to the lid in the kernel have no hook, so
they end up installing a second ACPI_DEVICE_NOTIFY handler on the same
lid object and reimplementing the _LID evaluation.

Add acpi_lid_event, invoked from acpi_lid_status_update() alongside the
existing devd notification, carrying the new state (1 open, 0 closed).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

seuros created this revision.Tue, Oct 13, 3:46 PM

Herald added a reviewer: olce. · View Herald TranscriptTue, Oct 13, 3:46 PM

Herald added a subscriber: imp. · View Herald Transcript

seuros requested review of this revision.Tue, Oct 13, 3:46 PM

Harbormaster completed remote builds in B78131: Diff 189738.Tue, Oct 13, 3:46 PM

oh neat, are there places we can delete these notifications from once this is landed?

In tree ? none. we missing it.

The first ones could be apple_acpi, and the kmod (intel/amd)

seuros added a child revision: D58867: acpi_apple: Apple platform ACPI driver,.Tue, Oct 13, 4:37 PM

adrian accepted this revision.Tue, Oct 13, 5:38 PM

This revision is now accepted and ready to land.Tue, Oct 13, 5:38 PM

Closed by commit rG030e556ff8a9: acpi_lid: add an in-kernel lid state eventhandler (authored by seuros). · Explain WhyTue, Oct 13, 6:44 PM

This revision was automatically updated to reflect the committed changes.

seuros added a commit: rG030e556ff8a9: acpi_lid: add an in-kernel lid state eventhandler.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

3 lines

5 lines

Diff 189766

sys/dev/acpica/acpi_lid.c

Loading...

sys/dev/acpica/acpivar.h

Loading...