bhyve: Add rfb unix socket access rights configuration
Needs ReviewPublic
Actions

Authored by quentin.thebault_defenso.fr on Mon, Oct 5, 5:58 AM.

Details

Reviewers

kevans
markj
ziaee

Group Reviewers

bhyve

Summary

Allow configuring the user, group and mode of the rfb unix socket to
make guest console access management easier. By default, the socket
remains created with the current bhyve process user and their group
as owners and a default mode of 0600.

Sponsored by: Defenso
MFC after: 2 weeks
Signed-off-by: Quentin Thébault <quentin.thebault@defenso.fr>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77712
Build 74595: arc lint + arc unit

Event Timeline

quentin.thebault_defenso.fr created this revision.Mon, Oct 5, 5:58 AM

Herald added a reviewer: bhyve. · View Herald TranscriptMon, Oct 5, 5:58 AM

Herald added subscribers: ziaee, bcran, rgrimes, imp. · View Herald Transcript

quentin.thebault_defenso.fr requested review of this revision.Mon, Oct 5, 5:58 AM

Harbormaster completed remote builds in B77712: Diff 188696.Mon, Oct 5, 5:58 AM

quentin.thebault_defenso.fr added a reviewer: ziaee.Mon, Oct 5, 6:06 AM

quentin.thebault_defenso.fr added inline comments.Mon, Oct 5, 6:11 AM

usr.sbin/bhyve/bhyve.8
1021	@ziaee I had a little hesitation on whether to keep a space (switching back to `No`) after `Ar mode` here. I chose not to because that would be how we do it in standard English and it did not seem to hurt legibility. What do you think?