Page MenuHomeFreeBSD

bhyve: namescope virtio_msix to virtio.msix
AcceptedPublic

Authored by njain15_protonmail.com on Wed, Jul 22, 1:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 29, 1:41 PM
Unknown Object (File)
Tue, Jul 28, 3:46 AM
Unknown Object (File)
Mon, Jul 27, 5:43 PM
Unknown Object (File)
Sun, Jul 26, 10:37 AM
Unknown Object (File)
Sun, Jul 26, 8:30 AM
Unknown Object (File)
Sun, Jul 26, 5:45 AM
Unknown Object (File)
Sun, Jul 26, 5:21 AM
Unknown Object (File)
Sat, Jul 25, 10:20 AM

Details

Reviewers
andrew
markj
Group Reviewers
bhyve

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

markj added a subscriber: markj.
markj added inline comments.
usr.sbin/bhyve/riscv/bhyverun_machdep.c
188

Extra newline here.

This revision is now accepted and ready to land.Thu, Jul 23, 4:42 PM
jhb added inline comments.
usr.sbin/bhyve/bhyverun.c
250

I think you can actually get rid of msg as a separate argument and instead just use new. I would also split this into two commits: one to add bhyve_cfg_warn() and to use it in place of the existing checks, and a second to just do virtio.msix.