bhyve: namescope virtio_msix to virtio.msix

[njain15_protonmail.com]

Summary

The bhyve_config(5) variable virtio_msix is namescoped to virtio.msix. Any configurations that have the old variable will automatically be mapped to the new one, with a warning message printed out.

Relnotes: yes

[markj]

usr.sbin/bhyve/riscv/bhyverun_machdep.c

188

Extra newline here.

[jhb]

usr.sbin/bhyve/bhyverun.c

250

I think you can actually get rid of msg as a separate argument and instead just use new. I would also split this into two commits: one to add bhyve_cfg_warn() and to use it in place of the existing checks, and a second to just do virtio.msix.

[njain15_protonmail.com]

Updated per reviewer comments. D58636 is the parent revision, adding the deprecation warning function.

I am not sure how to get Phabricator to only show the diff relative to the parent revision.

[ziaee]

Should we put something in UPDATING?

[emaste]

@ziaee Yes I think this should be noted in UPDATING.

[markj]

In D58390#1345632, @emaste wrote:

@ziaee Yes I think this should be noted in UPDATING.

RELNOTES would be more appropriate. UPDATING is for users tracking main.

[ziaee]

In D58390#1345816, @markj wrote:

In D58390#1345632, @emaste wrote:

@ziaee Yes I think this should be noted in UPDATING.

RELNOTES would be more appropriate. UPDATING is for users tracking main.

LGTM with Relnotes: yes.

[njain15_protonmail.com]

In D58390#1345882, @ziaee wrote:

In D58390#1345816, @markj wrote:

In D58390#1345632, @emaste wrote:

@ziaee Yes I think this should be noted in UPDATING.

RELNOTES would be more appropriate. UPDATING is for users tracking main.

LGTM with Relnotes: yes.

I edited the summary with a message and this tag. Is this the right way?