Page MenuHomeFreeBSD

build: don't create duplicate bootstrap-tools targets
ClosedPublic

Authored by kevans on Sat, Oct 4, 4:56 PM.
Tags
None
Referenced Files
F131709106: D52904.diff
Fri, Oct 10, 1:05 PM
F131708462: D52904.diff
Fri, Oct 10, 12:57 PM
Unknown Object (File)
Thu, Oct 9, 5:04 PM
Unknown Object (File)
Thu, Oct 9, 6:39 AM
Unknown Object (File)
Sun, Oct 5, 10:39 AM
Unknown Object (File)
Sat, Oct 4, 10:11 PM
Unknown Object (File)
Sat, Oct 4, 8:34 PM
Unknown Object (File)
Sat, Oct 4, 7:52 PM
Subscribers

Details

Summary

The general problem is that we might have a somewhat complicated
dependency tree depending on bootstrap version requirements. We could
document when multiple bootstrap tools might have a shared dependency
and be careful to add them only once to the list, but that is a little
more fragile- particularly if we purge some bootstrap tools and need to
re-work the logic a little bit.

Just avoid redefining the build commands as we're iterating over the
list so that we can keep the actual requirements intact.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans requested review of this revision.Sat, Oct 4, 4:56 PM

This is obscure enough we may want to have a comment..

This revision is now accepted and ready to land.Sat, Oct 4, 6:49 PM

The suggested change was effective in my testing.

In D52904#1208870, @imp wrote:

This is obscure enough we may want to have a comment..

I'll add a note