Page MenuHomeFreeBSD
Differential D52904

build: don't create duplicate bootstrap-tools targets
ClosedPublic
Actions

Authored by kevans on Sat, Oct 4, 4:56 PM.
Tags
None
Referenced Files
F131709106: D52904.diff
Fri, Oct 10, 1:05 PM
F131708462: D52904.diff
Fri, Oct 10, 12:57 PM
Unknown Object (File)
Thu, Oct 9, 5:04 PM
Unknown Object (File)
Thu, Oct 9, 6:39 AM
Unknown Object (File)
Sun, Oct 5, 10:39 AM
Unknown Object (File)
Sat, Oct 4, 10:11 PM
Unknown Object (File)
Sat, Oct 4, 8:34 PM
Unknown Object (File)
Sat, Oct 4, 7:52 PM
View All 10 Files
Subscribers
dhw
imp

Details

Reviewers
brooks
emaste
jrtc27
imp
Commits
rGab492c08fc3c: build: don't create duplicate bootstrap-tools targets
Summary

The general problem is that we might have a somewhat complicated
dependency tree depending on bootstrap version requirements. We could
document when multiple bootstrap tools might have a shared dependency
and be careful to add them only once to the list, but that is a little
more fragile- particularly if we purge some bootstrap tools and need to
re-work the logic a little bit.

Just avoid redefining the build commands as we're iterating over the
list so that we can keep the actual requirements intact.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67549
Build 64432: arc lint + arc unit

Event Timeline

kevans created this revision.Sat, Oct 4, 4:56 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Oct 4, 4:56 PM
kevans requested review of this revision.Sat, Oct 4, 4:56 PM
Harbormaster completed remote builds in B67549: Diff 163546.Sat, Oct 4, 4:56 PM
imp accepted this revision.Sat, Oct 4, 6:49 PM

This is obscure enough we may want to have a comment..

This revision is now accepted and ready to land.Sat, Oct 4, 6:49 PM
imp added a comment.Sun, Oct 5, 3:05 PM

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289997

dhw added a subscriber: dhw.Mon, Oct 6, 10:56 AM

The suggested change was effective in my testing.

kevans added a comment.Mon, Oct 6, 5:44 PM
In D52904#1208870, @imp wrote:

This is obscure enough we may want to have a comment..

I'll add a note

Closed by commit rGab492c08fc3c: build: don't create duplicate bootstrap-tools targets (authored by kevans). · Explain WhyMon, Oct 6, 5:52 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rGab492c08fc3c: build: don't create duplicate bootstrap-tools targets.

Revision Contents
Changeset List

PathSize
3 lines

Diff 163546

View Options

Makefile.inc1

Loading...