Page MenuHomeFreeBSD

pkgbootstrap: Gate building from ports
AcceptedPublic

Authored by cperciva on Fri, Sep 19, 4:50 PM.
Tags
None
Referenced Files
F131598247: D52624.id162427.diff
Thu, Oct 9, 3:01 PM
F131598218: D52624.id.diff
Thu, Oct 9, 3:01 PM
F131592945: D52624.diff
Thu, Oct 9, 1:55 PM
Unknown Object (File)
Fri, Oct 3, 2:57 PM
Unknown Object (File)
Thu, Oct 2, 4:23 PM
Unknown Object (File)
Thu, Oct 2, 5:38 AM
Unknown Object (File)
Wed, Oct 1, 4:13 PM
Unknown Object (File)
Wed, Oct 1, 7:32 AM
Subscribers

Details

Reviewers
des
ivy
Summary

In release builds we want to build pkg from the ports tree for reasons
mentioned in a previous commit; but non-release pkgbase builds may be
just fine with installing pkg from pkg.freebsd.org.

Gate it behind BOOTSTRAP_PKG_FROM_PORTS rather than building form ports
any time we have a ports tree available.

While I'm here, make the pkgbase-repo target in release/Makefile
create the temporary directories we need for building.

MFC after: 6 hours
Sponsored by: https://www.patreon.com/cperciva
Fixes: 2c06b824436d ("pkgbootstrap: Build pkg if PORTSDIR exists")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67173
Build 64056: arc lint + arc unit

Event Timeline

i'm okay with this on the basis that it turns the pkg problem into a release thing and not something that affects all developers. we definitely need a better way to do this, but i think everyone is aware of that at this point :-)

release/Makefile
198

i really don't like the hardcoded paths here, i'd like to see this fixed to use mkdtemp(1), although i won't insist on that for this change.

This revision is now accepted and ready to land.Fri, Sep 19, 5:00 PM
release/Makefile
198

Yeah, using a temporary directory, or having it configured elsewhere, would be better; but right now I'm in "get this thing building" mode rather than "do it cleanly" mode. :-/