Page MenuHomeFreeBSD

bridge: Print a warning if member_ifaddrs=1
ClosedPublic

Authored by ivy on Sep 2 2025, 9:55 AM.
Tags
None
Referenced Files
F132341398: D52335.id161375.diff
Thu, Oct 16, 1:47 AM
Unknown Object (File)
Wed, Oct 15, 7:00 AM
Unknown Object (File)
Sun, Oct 12, 8:19 PM
Unknown Object (File)
Sun, Oct 12, 8:19 PM
Unknown Object (File)
Sun, Oct 12, 8:19 PM
Unknown Object (File)
Sun, Oct 12, 8:19 PM
Unknown Object (File)
Sun, Oct 12, 8:43 AM
Unknown Object (File)
Wed, Oct 8, 12:39 PM

Details

Summary

When adding an interface with an IP address to a bridge, or assigning an
IP address to an interface which is in a bridge, and member_ifaddrs=1,
print a warning so users are informed this is deprecated. Also add
"(deprecated)" to the sysctl description.

This is in preparation for a separate commit which will change the
default value of member_ifaddrs to 1 in stable/15.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy requested review of this revision.Sep 2 2025, 9:55 AM
zlei added inline comments.
sys/net/if_bridge.c
1465

I guess that would generate too many warnings. I know some people have lots of member interfaces added to bridge interface.

sys/net/if_bridge.c
1465

do all of those interfaces have IP addresses assigned? the usual case is one interface has an IP address, which does work in many cases. having multiple interfaces with different IP addresses in the same bridge doesn't sound like it would work at all.

sys/net/if_bridge.c
1465

Ahh, fair. The most common case should be that only one UPLINK interface has IP address assigned, and added to the bridge interface, and other members are VMs ( tap ) or vnet jails ( epair ).

markj added a subscriber: markj.
markj added inline comments.
sys/net/if_bridge.c
1465
This revision is now accepted and ready to land.Sep 4 2025, 2:42 PM
This revision was automatically updated to reflect the committed changes.