bridge: Print a warning if member_ifaddrs=1
ClosedPublic
Actions

Authored by ivy on Sep 2 2025, 9:55 AM.

Details

Reviewers

Group Reviewers

network
bridge

Commits

rG7156a5f1af9e: bridge: Print a warning if member_ifaddrs=1

Summary

When adding an interface with an IP address to a bridge, or assigning an
IP address to an interface which is in a bridge, and member_ifaddrs=1,
print a warning so users are informed this is deprecated. Also add
"(deprecated)" to the sysctl description.

This is in preparation for a separate commit which will change the
default value of member_ifaddrs to 1 in stable/15.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Sep 2 2025, 9:55 AM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptSep 2 2025, 9:55 AM

ivy requested review of this revision.Sep 2 2025, 9:55 AM

Harbormaster completed remote builds in B66754: Diff 161364.Sep 2 2025, 9:55 AM

ivy mentioned this in D51156: 15.0R/relnotes: Add breaking bridge changes.Sep 2 2025, 10:06 AM

ivy added a child revision: D52336: bridge: Set member_ifaddrs=1 by default.

zlei added a subscriber: zlei.Sep 2 2025, 2:55 PM

zlei added inline comments.

sys/net/if_bridge.c
1465	I guess that would generate too many warnings. I know some people have lots of member interfaces added to bridge interface.

ivy added inline comments.Sep 2 2025, 2:58 PM

sys/net/if_bridge.c
1465	do all of those interfaces have IP addresses assigned? the usual case is one interface has an IP address, which does work in many cases. having multiple interfaces with different IP addresses in the same bridge doesn't sound like it would work at all.

fix a comment typo

Harbormaster completed remote builds in B66760: Diff 161375.Sep 2 2025, 3:01 PM

zlei added inline comments.Sep 2 2025, 4:20 PM

sys/net/if_bridge.c
1465	Ahh, fair. The most common case should be that only one UPLINK interface has IP address assigned, and added to the bridge interface, and other members are VMs ( tap ) or vnet jails ( epair ).