Page MenuHomeFreeBSD

if_bridge: Mask MEXTPG if some members don't support it
ClosedPublic

Authored by markj on Oct 26 2024, 6:36 PM.
Tags
None
Referenced Files
F107368839: D47294.id.diff
Mon, Jan 13, 3:57 AM
Unknown Object (File)
Sun, Jan 5, 3:35 PM
Unknown Object (File)
Dec 5 2024, 3:59 PM
Unknown Object (File)
Dec 5 2024, 1:27 AM
Unknown Object (File)
Dec 4 2024, 7:21 PM
Unknown Object (File)
Dec 1 2024, 1:00 PM
Unknown Object (File)
Nov 15 2024, 3:53 PM
Unknown Object (File)
Nov 15 2024, 2:45 PM

Details

Summary

Similar to how the network stack needs to use mb_unmapped_to_ext()
to convert mbufs before passing them to an unsupported driver, if_bridge
needs to avoid passing M_EXTPG mbufs to interfaces. Thus, clear
IFCAP_MEXTPG if any member interfaces don't handle unmapped mbufs.

PR: 278245
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Oct 26 2024, 6:36 PM
This revision is now accepted and ready to land.Oct 28 2024, 1:41 PM

Why do we want or need a hardcoded list? Why can't this function be more like lagg_capabilities()? If we do want a hardcoded list, what about IFCAP_TXTLS*

Why do we want or need a hardcoded list? Why can't this function be more like lagg_capabilities()? If we do want a hardcoded list, what about IFCAP_TXTLS*

That's a good question. if_bridge could probably be smarter, indeed.

Why exactly does if_bridge need to care about IFCAP_TXTLS*?

Why do we want or need a hardcoded list? Why can't this function be more like lagg_capabilities()? If we do want a hardcoded list, what about IFCAP_TXTLS*

That's a good question. if_bridge could probably be smarter, indeed.

Why exactly does if_bridge need to care about IFCAP_TXTLS*?

The same reason lagg does.... if its enabled (along with MEXTPG) and the bridge interface is used as an egress interface, we'll at the very least attempt to alloc a send tag.. I'm not 100% certain it would be a problem, but it seems more obvious to mask the feature off