Page MenuHomeFreeBSD

sys: Nuke double-semicolons
Needs ReviewPublic

Authored by ehem_freebsd_m5p.com on Aug 29 2021, 10:08 PM.

Details

Reviewers
manu
emaste
Group Reviewers
transport
Summary

A distinct number of double-semicolons have ended up in FreeBSD. Take a
pass at getting rid of many of these harmless typos.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 41273
Build 38162: arc lint + arc unit

Event Timeline

Please don't do the pms ones. That's vendor code that needs to be moved to contrib/sys.

The rest look good to me.

Pulling the hunks from sys/dev/pms/RefTisa. Those did look kind of odd.

Pulling one hunk in light of 0637070b5bc, which seems a bit odd.

Pulling one hunk in light of 0637070b5bc, which seems a bit odd.

That one was sitting in a local tree for some time, waiting on replies from maintainers or upstreams.
(same case for 8fa63f44e64ebac444a4ac6451ac5e150cdcf8b1, b1a217a369186dc45c7df7bde13a87868fd5b2c8, 11224884f285481ccecb61f57381b51661d77c6d)

rrs added inline comments.
sys/netinet/sctp_timer.c
332

Make sure to make Michael Tuexen aware of this change since you are changing here not
the code of SCTP, thats in a different git repo and has a bunch of undef scrubbers that
run on it before submitting to freebsd... so he will need to pull in these changes to the
sctp git repo

tuexen added inline comments.
sys/netinet/sctp_timer.c
332

I committed this already to the FreeBSD tree and also to the upstream repositories in 454216468583481746845a1c8a45a8c18898ee72