Differential D30197

Remove a write-only variable.
ClosedPublic
Actions

Authored by jhb on May 10 2021, 8:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 14, 3:34 PM

	Unknown Object (File)
	Sat, Oct 11, 7:55 AM

	Unknown Object (File)
	Sat, Oct 11, 7:55 AM

	Unknown Object (File)
	Sat, Oct 11, 7:54 AM

	Unknown Object (File)
	Sat, Oct 11, 12:35 AM

	Unknown Object (File)
	Tue, Oct 7, 4:26 PM

	Unknown Object (File)
	Tue, Sep 16, 8:13 PM

	Unknown Object (File)
	Sep 7 2025, 12:20 PM

Subscribers

Details

Reviewers

brooks
kib
imp

Commits

rG5fbf51588d20: Remove a write-only variable.
rGed93deba1106: Remove a write-only variable.

Summary

While refactoring an earlier series of changes during review, the
'saved_data' variable stopped being used at the bottom of if_ioctl().

Suggested by: brooks
Fixes: d17e0940f79f Rework compat shims in ifioctl().
Sponsored by: DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.May 10 2021, 8:32 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptMay 10 2021, 8:32 PM

jhb requested review of this revision.May 10 2021, 8:32 PM

Harbormaster completed remote builds in B39109: Diff 88987.May 10 2021, 8:32 PM

brooks accepted this revision.May 10 2021, 8:41 PM

This revision is now accepted and ready to land.May 10 2021, 8:41 PM

kib accepted this revision.May 10 2021, 9:31 PM

imp accepted this revision.May 11 2021, 3:50 AM

Closed by commit rGed93deba1106: Remove a write-only variable. (authored by jhb). · Explain WhyMay 11 2021, 9:57 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGed93deba1106: Remove a write-only variable..

jhb added a commit: rG5fbf51588d20: Remove a write-only variable..Nov 10 2022, 7:15 PM

Herald added a subscriber: glebius. · View Herald TranscriptNov 10 2022, 7:15 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

2 lines

Diff 89047

sys/net/if.c

Loading...